Source/bindings/scripts/v8_attributes.py - Issue 313993002: Bindings: Add ScalarValueString support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 313993002: Bindings: Add ScalarValueString support (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Incorporate review feedback Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 46ea36fda60198eb405e250046fb420934db9bf8..c4c372211aaad3d23d41c0daa4fbcddf6709cfad 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -108,7 +108,8 @@ def generate_attribute(interface, attribute):

'has_setter_exception_state':

is_setter_raises_exception or has_type_checking_interface or

has_type_checking_nullable or has_type_checking_unrestricted or

- idl_type.is_integer_type or idl_type.name == 'ByteString',

+ idl_type.is_integer_type or

+ idl_type.name in ('ByteString', 'ScalarValueString'),

'has_type_checking_interface': has_type_checking_interface,

'has_type_checking_nullable': has_type_checking_nullable,

'has_type_checking_unrestricted': has_type_checking_unrestricted,