Issue 313923005: Revert 273875 "Remove the option to skip auto-update checks on OOBE."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 313923005: Revert 273875 "Remove the option to skip auto-update checks on OOBE." (Closed)

Created:
6 years, 6 months ago by pastarmovj

Modified:
6 years, 6 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 273875 "Remove the option to skip auto-update checks on OOBE." This change was introduced for the sake of merging it back to M36. All relevant changes that make this CL obsolete are already part of M37 and the presence of this CL makes it impossible to test these. > Remove the option to skip auto-update checks on OOBE. > > This is the simpler version of actually making sure that even if it > skipped it will not allow forced reenrollment to be circumvented. > > This option will be reintroduced in the first stable version to contain > all other safeguards in place. > BUG=378953 > > Review URL: https://codereview.chromium.org/306993004 TBR=pastarmovj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274858

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+67 lines, -1 line)			Patch
M	trunk/src/chrome/browser/chromeos/login/wizard_controller.h	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/wizard_controller.cc	View	3 chunks	+12 lines, -1 line	0 comments	Download
M	trunk/src/chrome/browser/chromeos/login/wizard_controller_browsertest.cc	View	1 chunk	+33 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/resources/login/display_manager.js	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	trunk/src/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View	3 chunks	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r274858.

Expand Messages | Collapse Messages