Issue 306993004: Remove the option to skip auto-update checks on OOBE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 306993004: Remove the option to skip auto-update checks on OOBE. (Closed)

Created:
6 years, 6 months ago by pastarmovj

Modified:
6 years, 6 months ago

Reviewers:
Nikita (slow), ygorshenin1

CC:
chromium-reviews, arv+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove the option to skip auto-update checks on OOBE. This is the simpler version of actually making sure that even if it skipped it will not allow forced reenrollment to be circumvented. This option will be reintroduced in the first stable version to contain all other safeguards in place. BUG=378953 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273875

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -67 lines)			Patch
M	chrome/browser/chromeos/login/wizard_controller.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller.cc	View	3 chunks	+1 line, -12 lines	0 comments	Download
M	chrome/browser/chromeos/login/wizard_controller_browsertest.cc	View	1 chunk	+0 lines, -33 lines	0 comments	Download
M	chrome/browser/resources/login/display_manager.js	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View	3 chunks	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

pastarmovj

Hey, one more CL that is intended to go in mainly for merging purposes and ...

6 years, 6 months ago (2014-05-30 15:10:27 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pastarmovj@chromium.org/306993004/1

6 years, 6 months ago (2014-05-30 15:18:27 UTC) #4

Message was sent while issue was closed.

Change committed as 273875

Expand Messages | Collapse Messages