Issue 3138001: CommandLine: remove PrefixedSwitchString().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3138001: CommandLine: remove PrefixedSwitchString(). (Closed)

Created:
10 years, 4 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, ben+cc_chromium.org, brettw-cc_chromium.org

Visibility:
Public.

Description

CommandLine: remove three useless functions. PrefixedSwitchString was full of encoding conversions, but there was only one real caller, and the function is trivial. Terminate is leftover cruft. TEST=compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55931

Patch Set 1 #

Patch Set 2 : works #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -45 lines)			Patch
M	base/command_line.h	View		2 chunks	+0 lines, -13 lines	0 comments	Download
M	base/command_line.cc	View	1	3 chunks	+8 lines, -31 lines	0 comments	Download
M	chrome/browser/jumplist_win.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM.

Expand Messages | Collapse Messages