Introduces --app flag to athena to load an app.

Introduces --app flag to athena to load an app.

Just loading, do nothing to the loaded app for now. Following CL
will embed the loaded app into AppActivity (combined with
crrev.com/311113005)

BUG=380421
R=jamescook@chromium.org, oshima@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276316

[James Cook, 2014-06-09 21:59:30]

LGTM with a couple suggestions

https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_ext...
File apps/shell/browser/shell_extension_system.cc (right):

https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_ext...
apps/shell/browser/shell_extension_system.cc:40: bool
ShellExtensionSystem::LoadAndLaunchApp(const base::FilePath& app_dir) {
I suggest getting rid of this method and just calling LoadApp() and LaunchApp()
inside app_shell.

https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_ext...
apps/shell/browser/shell_extension_system.cc:91: // Send the onLaunched event.
DCHECK(extension_.get()) ?

[Jun Mukai, 2014-06-09 22:04:09]

https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_ext...
File apps/shell/browser/shell_extension_system.cc (right):

https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_ext...
apps/shell/browser/shell_extension_system.cc:40: bool
ShellExtensionSystem::LoadAndLaunchApp(const base::FilePath& app_dir) {
On 2014/06/09 21:59:30, James Cook wrote:
> I suggest getting rid of this method and just calling LoadApp() and
LaunchApp()
> inside app_shell.

Done.

https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_ext...
apps/shell/browser/shell_extension_system.cc:91: // Send the onLaunched event.
On 2014/06/09 21:59:30, James Cook wrote:
> DCHECK(extension_.get()) ?

Done.

[James Cook, 2014-06-09 22:11:02]

lgtm

[oshima, 2014-06-09 22:26:09]

lgtm

[Jun Mukai, 2014-06-09 22:28:37]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-06-09 22:31:43]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/313733005/20001

[commit-bot: I haz the power, 2014-06-10 13:21:01]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-06-10 13:58:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 13:58:59]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[Jun Mukai, 2014-06-10 23:22:52]

The CQ bit was checked by mukai@chromium.org

[commit-bot: I haz the power, 2014-06-10 23:24:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mukai@chromium.org/313733005/40001

[commit-bot: I haz the power, 2014-06-11 09:18:34]

Change committed as 276316