Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 313733005: Introduces --app flag to athena to load an app. (Closed)

Created:
6 years, 6 months ago by Jun Mukai
Modified:
6 years, 6 months ago
Reviewers:
James Cook, oshima
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Introduces --app flag to athena to load an app. Just loading, do nothing to the loaded app for now. Following CL will embed the loaded app into AppActivity (combined with crrev.com/311113005) BUG=380421 R=jamescook@chromium.org, oshima@chromium.org TEST=manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276316

Patch Set 1 #

Total comments: 4

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -15 lines) Patch
M apps/shell/browser/default_shell_browser_main_delegate.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M apps/shell/browser/shell_extension_system.h View 1 2 chunks +7 lines, -3 lines 0 comments Download
M apps/shell/browser/shell_extension_system.cc View 1 3 chunks +13 lines, -10 lines 0 comments Download
M apps/shell/test/shell_test.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M athena/main/athena_main.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Jun Mukai
6 years, 6 months ago (2014-06-09 20:55:41 UTC) #1
James Cook
LGTM with a couple suggestions https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_extension_system.cc File apps/shell/browser/shell_extension_system.cc (right): https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_extension_system.cc#newcode40 apps/shell/browser/shell_extension_system.cc:40: bool ShellExtensionSystem::LoadAndLaunchApp(const base::FilePath& app_dir) ...
6 years, 6 months ago (2014-06-09 21:59:30 UTC) #2
Jun Mukai
https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_extension_system.cc File apps/shell/browser/shell_extension_system.cc (right): https://codereview.chromium.org/313733005/diff/1/apps/shell/browser/shell_extension_system.cc#newcode40 apps/shell/browser/shell_extension_system.cc:40: bool ShellExtensionSystem::LoadAndLaunchApp(const base::FilePath& app_dir) { On 2014/06/09 21:59:30, James ...
6 years, 6 months ago (2014-06-09 22:04:09 UTC) #3
James Cook
lgtm
6 years, 6 months ago (2014-06-09 22:11:02 UTC) #4
oshima
lgtm
6 years, 6 months ago (2014-06-09 22:26:09 UTC) #5
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-09 22:28:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/313733005/20001
6 years, 6 months ago (2014-06-09 22:31:43 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 13:21:01 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 13:58:58 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150337)
6 years, 6 months ago (2014-06-10 13:58:59 UTC) #10
Jun Mukai
The CQ bit was checked by mukai@chromium.org
6 years, 6 months ago (2014-06-10 23:22:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/313733005/40001
6 years, 6 months ago (2014-06-10 23:24:11 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 09:18:34 UTC) #13
Message was sent while issue was closed.
Change committed as 276316

Powered by Google App Engine
This is Rietveld 408576698