Introduces --app flag to athena to load an app.

apps/shell/browser/shell_extension_system.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "apps/shell/browser/shell_extension_system.h"
 
 #include <string>
 
 #include "apps/shell/browser/api/shell/shell_api.h"
 #include "base/file_util.h"
@@ skipping 19 matching lines @@
 
 namespace extensions {
 
 ShellExtensionSystem::ShellExtensionSystem(BrowserContext* browser_context)
     : browser_context_(browser_context) {
 }
 
 ShellExtensionSystem::~ShellExtensionSystem() {
 }
 
 bool ShellExtensionSystem::LoadAndLaunchApp(const base::FilePath& app_dir) {

[James Cook, 2014/06/09 21:59:30]

I suggest getting rid of this method and just calling LoadApp() and LaunchApp()
inside app_shell.

[Jun Mukai, 2014/06/09 22:04:08]

Done.

+  if (!extension_) {
+    if (!LoadApp(app_dir))
+      return false;
+  }
+  LaunchApp();
+  return true;
+}
+
+bool ShellExtensionSystem::LoadApp(const base::FilePath& app_dir) {
   // app_shell only supports unpacked extensions.
   // NOTE: If you add packed extension support consider removing the flag
   // FOLLOW_SYMLINKS_ANYWHERE below. Packed extensions should not have symlinks.
   CHECK(base::DirectoryExists(app_dir)) << app_dir.AsUTF8Unsafe();
   int load_flags = Extension::FOLLOW_SYMLINKS_ANYWHERE;
   std::string load_error;
-  scoped_refptr<Extension> extension = file_util::LoadExtension(
+  extension_ = file_util::LoadExtension(
       app_dir, Manifest::COMMAND_LINE, load_flags, &load_error);
-  if (!extension) {
+  if (!extension_) {
     LOG(ERROR) << "Loading extension at " << app_dir.value()
         << " failed with: " << load_error;
     return false;
   }
-  app_id_ = extension->id();
+  app_id_ = extension_->id();
 
   // TODO(jamescook): We may want to do some of these things here:
   // * Create a PermissionsUpdater.
   // * Call PermissionsUpdater::GrantActivePermissions().
   // * Call ExtensionService::SatisfyImports().
   // * Call ExtensionPrefs::OnExtensionInstalled().
   // * Send NOTIFICATION_EXTENSION_INSTALLED_DEPRECATED.
 
-  ExtensionRegistry::Get(browser_context_)->AddEnabled(extension);
+  ExtensionRegistry::Get(browser_context_)->AddEnabled(extension_);
 
-  RegisterExtensionWithRequestContexts(extension);
+  RegisterExtensionWithRequestContexts(extension_);
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSION_LOADED_DEPRECATED,
       content::Source<BrowserContext>(browser_context_),
-      content::Details<const Extension>(extension));
+      content::Details<const Extension>(extension_));
 
   // Inform the rest of the extensions system to start.
   ready_.Signal();
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_EXTENSIONS_READY,
       content::Source<BrowserContext>(browser_context_),
       content::NotificationService::NoDetails());
-
-  // Send the onLaunched event.
-  apps::ShellAPI::DispatchOnLaunchedEvent(event_router_.get(), extension.get());
-
   return true;
 }
 
+void ShellExtensionSystem::LaunchApp() {
+  // Send the onLaunched event.

[James Cook, 2014/06/09 21:59:30]

DCHECK(extension_.get()) ?

[Jun Mukai, 2014/06/09 22:04:08]

Done.

+  apps::ShellAPI::DispatchOnLaunchedEvent(event_router_.get(),
+                                          extension_.get());
+}
+
 void ShellExtensionSystem::Shutdown() {
 }
 
 void ShellExtensionSystem::InitForRegularProfile(bool extensions_enabled) {
   runtime_data_.reset(
       new RuntimeData(ExtensionRegistry::Get(browser_context_)));
   lazy_background_task_queue_.reset(
       new LazyBackgroundTaskQueue(browser_context_));
   event_router_.reset(
       new EventRouter(browser_context_, ExtensionPrefs::Get(browser_context_)));
@@ skipping 79 matching lines @@
 
 const OneShotEvent& ShellExtensionSystem::ready() const {
   return ready_;
 }
 
 ContentVerifier* ShellExtensionSystem::content_verifier() {
   return NULL;
 }
 
 }  // namespace extensions