Convert local printer capabilites to CDD format to unify with cloud printers and PDF printer. This …

Convert local printer capabilites to CDD format to unify with cloud printers and PDF printer. This is a necessary step for adding paper size capability to local printers.

BUG=239879
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275250

[Vitaly Buka (NO REVIEWS), 2014-06-04 00:05:46]

lgtm

split?

https://codereview.chromium.org/313723002/diff/1/chrome/browser/ui/webui/prin...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/313723002/diff/1/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:377: if
(description == NULL) {
if (!description)

https://codereview.chromium.org/313723002/diff/1/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:455: if
(printer_capabilities == NULL) {
if (!printer_capabilities) {

https://codereview.chromium.org/313723002/diff/1/chrome/service/cloud_print/p...
File chrome/service/cloud_print/print_system_win.cc (right):

https://codereview.chromium.org/313723002/diff/1/chrome/service/cloud_print/p...
chrome/service/cloud_print/print_system_win.cc:572:
base::JSONWriter::WriteWithOptions(
empty string?

https://codereview.chromium.org/313723002/diff/1/chrome/test/data/webui/print...
File chrome/test/data/webui/print_preview.js (right):

https://codereview.chromium.org/313723002/diff/1/chrome/test/data/webui/print...
chrome/test/data/webui/print_preview.js:1002: {"type": "LONG_EDGE"},
duplicates?

https://codereview.chromium.org/313723002/diff/1/printing/backend/print_backe...
File printing/backend/print_backend.h (right):

https://codereview.chromium.org/313723002/diff/1/printing/backend/print_backe...
printing/backend/print_backend.h:52: #if defined(OS_POSIX)
Comment?

[Aleksey Shlyapnikov, 2014-06-04 02:02:48]

Justin: for changes in chrome/common/chrome_utility_messages.h

https://codereview.chromium.org/313723002/diff/1/chrome/browser/ui/webui/prin...
File chrome/browser/ui/webui/print_preview/print_preview_handler.cc (right):

https://codereview.chromium.org/313723002/diff/1/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:377: if
(description == NULL) {
On 2014/06/04 00:05:46, Vitaly Buka wrote:
> if (!description)

Done.

https://codereview.chromium.org/313723002/diff/1/chrome/browser/ui/webui/prin...
chrome/browser/ui/webui/print_preview/print_preview_handler.cc:455: if
(printer_capabilities == NULL) {
On 2014/06/04 00:05:46, Vitaly Buka wrote:
> if (!printer_capabilities) {

Done.

https://codereview.chromium.org/313723002/diff/1/chrome/service/cloud_print/p...
File chrome/service/cloud_print/print_system_win.cc (right):

https://codereview.chromium.org/313723002/diff/1/chrome/service/cloud_print/p...
chrome/service/cloud_print/print_system_win.cc:572:
base::JSONWriter::WriteWithOptions(
On 2014/06/04 00:05:46, Vitaly Buka wrote:
> empty string?

Done.

https://codereview.chromium.org/313723002/diff/1/chrome/test/data/webui/print...
File chrome/test/data/webui/print_preview.js (right):

https://codereview.chromium.org/313723002/diff/1/chrome/test/data/webui/print...
chrome/test/data/webui/print_preview.js:1002: {"type": "LONG_EDGE"},
On 2014/06/04 00:05:46, Vitaly Buka wrote:
> duplicates?

Done.

https://codereview.chromium.org/313723002/diff/1/printing/backend/print_backe...
File printing/backend/print_backend.h (right):

https://codereview.chromium.org/313723002/diff/1/printing/backend/print_backe...
printing/backend/print_backend.h:52: #if defined(OS_POSIX)
On 2014/06/04 00:05:46, Vitaly Buka wrote:
> Comment?

Done.

[jschuh, 2014-06-05 04:18:33]

rubberstamp lgtm (notes: reformatting)

[Vitaly Buka (NO REVIEWS), 2014-06-05 04:44:55]

The CQ bit was checked by vitalybuka@chromium.org

[commit-bot: I haz the power, 2014-06-05 04:45:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alekseys@chromium.org/313723002/20001

[commit-bot: I haz the power, 2014-06-05 08:27:18]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/13226)

[commit-bot: I haz the power, 2014-06-05 08:31:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 08:31:36]

Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[Aleksey Shlyapnikov, 2014-06-05 17:34:40]

The CQ bit was checked by alekseys@chromium.org

[commit-bot: I haz the power, 2014-06-05 17:36:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/alekseys@chromium.org/313723002/40001

[commit-bot: I haz the power, 2014-06-05 21:44:56]

Change committed as 275250