Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: printing/backend/cups_helper_unittest.cc

Issue 313723002: Convert local printer capabilites to CDD format to unify with cloud printers and PDF printer. This … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix clang reported errors. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « printing/backend/cups_helper.cc ('k') | printing/backend/print_backend.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: printing/backend/cups_helper_unittest.cc
diff --git a/printing/backend/cups_helper_unittest.cc b/printing/backend/cups_helper_unittest.cc
index 7f2b77cbe4e672735aada6d943ab5c544f1a7728..83dc0a1135e2654c932dc2a6db44dfc24247d0eb 100644
--- a/printing/backend/cups_helper_unittest.cc
+++ b/printing/backend/cups_helper_unittest.cc
@@ -33,10 +33,13 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingNoColorDuplexLongEdge) {
printing::PrinterSemanticCapsAndDefaults caps;
EXPECT_TRUE(printing::ParsePpdCapabilities("test", test_ppd_data, &caps));
- EXPECT_FALSE(caps.color_changeable);
- EXPECT_FALSE(caps.color_default);
+ EXPECT_TRUE(caps.collate_capable);
+ EXPECT_TRUE(caps.collate_default);
+ EXPECT_TRUE(caps.copies_capable);
EXPECT_TRUE(caps.duplex_capable);
EXPECT_EQ(caps.duplex_default, printing::LONG_EDGE);
+ EXPECT_FALSE(caps.color_changeable);
+ EXPECT_FALSE(caps.color_default);
}
// Test duplex detection code, which regressed in http://crbug.com/103999.
@@ -58,10 +61,13 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingNoColorDuplexSimples) {
printing::PrinterSemanticCapsAndDefaults caps;
EXPECT_TRUE(printing::ParsePpdCapabilities("test", test_ppd_data, &caps));
- EXPECT_FALSE(caps.color_changeable);
- EXPECT_FALSE(caps.color_default);
+ EXPECT_TRUE(caps.collate_capable);
+ EXPECT_TRUE(caps.collate_default);
+ EXPECT_TRUE(caps.copies_capable);
EXPECT_TRUE(caps.duplex_capable);
EXPECT_EQ(caps.duplex_default, printing::SIMPLEX);
+ EXPECT_FALSE(caps.color_changeable);
+ EXPECT_FALSE(caps.color_default);
}
TEST(PrintBackendCupsHelperTest, TestPpdParsingNoColorNoDuplex) {
@@ -82,10 +88,13 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingNoColorNoDuplex) {
printing::PrinterSemanticCapsAndDefaults caps;
EXPECT_TRUE(printing::ParsePpdCapabilities("test", test_ppd_data, &caps));
- EXPECT_FALSE(caps.color_changeable);
- EXPECT_FALSE(caps.color_default);
+ EXPECT_TRUE(caps.collate_capable);
+ EXPECT_TRUE(caps.collate_default);
+ EXPECT_TRUE(caps.copies_capable);
EXPECT_FALSE(caps.duplex_capable);
EXPECT_EQ(caps.duplex_default, printing::UNKNOWN_DUPLEX_MODE);
+ EXPECT_FALSE(caps.color_changeable);
+ EXPECT_FALSE(caps.color_default);
}
TEST(PrintBackendCupsHelperTest, TestPpdParsingColorTrueDuplexLongEdge) {
@@ -115,10 +124,13 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingColorTrueDuplexLongEdge) {
printing::PrinterSemanticCapsAndDefaults caps;
EXPECT_TRUE(printing::ParsePpdCapabilities("test", test_ppd_data, &caps));
- EXPECT_TRUE(caps.color_changeable);
- EXPECT_TRUE(caps.color_default);
+ EXPECT_TRUE(caps.collate_capable);
+ EXPECT_TRUE(caps.collate_default);
+ EXPECT_TRUE(caps.copies_capable);
EXPECT_TRUE(caps.duplex_capable);
EXPECT_EQ(caps.duplex_default, printing::LONG_EDGE);
+ EXPECT_TRUE(caps.color_changeable);
+ EXPECT_TRUE(caps.color_default);
}
TEST(PrintBackendCupsHelperTest, TestPpdParsingColorFalseDuplexLongEdge) {
@@ -152,8 +164,11 @@ TEST(PrintBackendCupsHelperTest, TestPpdParsingColorFalseDuplexLongEdge) {
printing::PrinterSemanticCapsAndDefaults caps;
EXPECT_TRUE(printing::ParsePpdCapabilities("test", test_ppd_data, &caps));
- EXPECT_TRUE(caps.color_changeable);
- EXPECT_FALSE(caps.color_default);
+ EXPECT_TRUE(caps.collate_capable);
+ EXPECT_TRUE(caps.collate_default);
+ EXPECT_TRUE(caps.copies_capable);
EXPECT_TRUE(caps.duplex_capable);
EXPECT_EQ(caps.duplex_default, printing::LONG_EDGE);
+ EXPECT_TRUE(caps.color_changeable);
+ EXPECT_FALSE(caps.color_default);
}
« no previous file with comments | « printing/backend/cups_helper.cc ('k') | printing/backend/print_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698