Reorder the calls in WebFrameTestProxy::didFinishLoad

Reorder the calls in WebFrameTestProxy::didFinishLoad

WebTestProxyBase::didFinishLoad does non-trivial work that can lead to the
WebFrameTestProxy being delete synchronously.

BUG=357283
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275240

[Nate Chapin, 2014-06-03 23:03:30]

jochen, what do you think of this?

Several months ago, we had discussed in the mentioned bug how
locationChangeDone() does substantial work, sometimes inside a callback
(didFinishLoad()) that we expect to be benign.

Reordering the work in WebFrameTestProxy::didFinishLoad() appears to allow the
stack to safely unwind as far as FrameLoader::checKLoadCompleteForThisFrame -
https://codereview.chromium.org/317513002/ resolves the unsafe there.

[jochen (gone - plz use gerrit), 2014-06-04 08:17:15]

lgtm

[Nate Chapin, 2014-06-04 16:40:04]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-06-04 16:43:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/japhet@chromium.org/313683004/1

[commit-bot: I haz the power, 2014-06-04 22:36:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-04 22:58:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 22:59:00]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[Nate Chapin, 2014-06-04 23:00:24]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-06-04 23:00:56]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/japhet@chromium.org/313683004/1

[commit-bot: I haz the power, 2014-06-04 23:38:19]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-06-04 23:45:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-04 23:45:05]

Try jobs failed on following builders:
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)

[Nate Chapin, 2014-06-05 20:59:49]

The CQ bit was checked by japhet@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:01:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/japhet@chromium.org/313683004/1

[commit-bot: I haz the power, 2014-06-05 21:13:28]

Change committed as 275240