tests/PictureStateTreeTest.cpp - Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureStateTreeTest.cpp

Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add staging entry point for Chromium and Android Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/PictureStateTreeTest.cpp

diff --git a/tests/PictureStateTreeTest.cpp b/tests/PictureStateTreeTest.cpp

index e6cf55342e38fe96a136ac20f468ff65623131f9..cb154def9683941b53f347e9d5267644deb197af 100644

--- a/tests/PictureStateTreeTest.cpp

+++ b/tests/PictureStateTreeTest.cpp

@@ -84,9 +84,9 @@ static void test_reference_picture(skiatest::Reporter* reporter) {

SkCanvas bbhCanvas(bbhBitmap);

referenceCanvas.drawColor(SK_ColorTRANSPARENT);

- referenceCanvas.drawPicture(*referencePicture.get());

+ referenceCanvas.drawPicture(referencePicture.get());

bbhCanvas.drawColor(SK_ColorTRANSPARENT);

- bbhCanvas.drawPicture(*bbhPicture.get());

+ bbhCanvas.drawPicture(bbhPicture.get());

REPORTER_ASSERT(reporter,

referenceCanvas.getSaveCount() == bbhCanvas.getSaveCount());

REPORTER_ASSERT(reporter,

@@ -95,10 +95,10 @@ static void test_reference_picture(skiatest::Reporter* reporter) {

referenceCanvas.drawColor(SK_ColorTRANSPARENT);

referenceCanvas.clipRect(SkRect::MakeWH(50, 50));

- referenceCanvas.drawPicture(*referencePicture.get());

+ referenceCanvas.drawPicture(referencePicture.get());

bbhCanvas.drawColor(SK_ColorTRANSPARENT);

bbhCanvas.clipRect(SkRect::MakeWH(50, 50));

- bbhCanvas.drawPicture(*bbhPicture.get());

+ bbhCanvas.drawPicture(bbhPicture.get());

REPORTER_ASSERT(reporter,

referenceCanvas.getSaveCount() == bbhCanvas.getSaveCount());

REPORTER_ASSERT(reporter,

@@ -107,10 +107,10 @@ static void test_reference_picture(skiatest::Reporter* reporter) {

referenceCanvas.drawColor(SK_ColorTRANSPARENT);

referenceCanvas.clipRect(SkRect::MakeWH(10, 10));

- referenceCanvas.drawPicture(*referencePicture.get());

+ referenceCanvas.drawPicture(referencePicture.get());

bbhCanvas.drawColor(SK_ColorTRANSPARENT);

bbhCanvas.clipRect(SkRect::MakeWH(10, 10));

- bbhCanvas.drawPicture(*bbhPicture.get());

+ bbhCanvas.drawPicture(bbhPicture.get());

REPORTER_ASSERT(reporter,

referenceCanvas.getSaveCount() == bbhCanvas.getSaveCount());

REPORTER_ASSERT(reporter,

« include/core/SkCanvas.h ('K') | « tests/ImageFilterTest.cpp ('k') | tests/PictureTest.cpp » ('j') | no next file with comments »