Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: tests/ImageFilterTest.cpp

Issue 313613004: Alter SkCanvas::drawPicture (devirtualize, take const SkPicture, take pointer) (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Add staging entry point for Chromium and Android Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/ImageFilterTest.cpp
diff --git a/tests/ImageFilterTest.cpp b/tests/ImageFilterTest.cpp
index 0c4d0766b56f48c148b1ee44e51d361c961b00c8..cd6d235dc59d4e5638cbb1291b31dcb08da12d10 100644
--- a/tests/ImageFilterTest.cpp
+++ b/tests/ImageFilterTest.cpp
@@ -491,7 +491,7 @@ DEF_TEST(ImageFilterMatrixTest, reporter) {
recordingCanvas->restore(); // saveLayer
SkAutoTUnref<SkPicture> picture(recorder.endRecording());
- canvas.drawPicture(*picture);
+ canvas.drawPicture(picture);
}
DEF_TEST(ImageFilterPictureImageFilterTest, reporter) {
@@ -529,7 +529,7 @@ DEF_TEST(ImageFilterPictureImageFilterTest, reporter) {
// The result here should be green, since the filter replaces the primitive's red interior.
canvas.clear(0x0);
- canvas.drawPicture(*outerPicture);
+ canvas.drawPicture(outerPicture);
uint32_t pixel = *bitmap.getAddr32(0, 0);
REPORTER_ASSERT(reporter, pixel == SK_ColorGREEN);
@@ -548,7 +548,7 @@ DEF_TEST(ImageFilterPictureImageFilterTest, reporter) {
SkAutoTUnref<SkPicture> crossProcessPicture(crossProcessRecorder.endRecording());
canvas.clear(0x0);
- canvas.drawPicture(*crossProcessPicture);
+ canvas.drawPicture(crossProcessPicture);
pixel = *bitmap.getAddr32(0, 0);
// The result here should not be green, since the filter draws nothing.
REPORTER_ASSERT(reporter, pixel != SK_ColorGREEN);
@@ -584,7 +584,7 @@ DEF_TEST(ImageFilterEmptySaveLayerTest, reporter) {
SkAutoTUnref<SkPicture> picture(recorder.endRecording());
canvas.clear(0);
- canvas.drawPicture(*picture);
+ canvas.drawPicture(picture);
uint32_t pixel = *bitmap.getAddr32(0, 0);
REPORTER_ASSERT(reporter, pixel == SK_ColorGREEN);
@@ -594,7 +594,7 @@ DEF_TEST(ImageFilterEmptySaveLayerTest, reporter) {
SkAutoTUnref<SkPicture> picture2(recorder.endRecording());
canvas.clear(0);
- canvas.drawPicture(*picture2);
+ canvas.drawPicture(picture2);
pixel = *bitmap.getAddr32(0, 0);
REPORTER_ASSERT(reporter, pixel == SK_ColorGREEN);
@@ -604,7 +604,7 @@ DEF_TEST(ImageFilterEmptySaveLayerTest, reporter) {
SkAutoTUnref<SkPicture> picture3(recorder.endRecording());
canvas.clear(0);
- canvas.drawPicture(*picture3);
+ canvas.drawPicture(picture3);
pixel = *bitmap.getAddr32(0, 0);
REPORTER_ASSERT(reporter, pixel == SK_ColorGREEN);
}

Powered by Google App Engine
This is Rietveld 408576698