Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1874)

Unified Diff: Source/devtools/front_end/sdk/Workspace.js

Issue 313603003: Devtools: get rid of ProjectWillReset event, introduce ProjectRemoved instead of it (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/Workspace.js
diff --git a/Source/devtools/front_end/sdk/Workspace.js b/Source/devtools/front_end/sdk/Workspace.js
index c0bd6624b836de480d208679f6e19d986c2d88a6..4670b5e9e04939fcb6da7d4804b5a9ecb089307f 100644
--- a/Source/devtools/front_end/sdk/Workspace.js
+++ b/Source/devtools/front_end/sdk/Workspace.js
@@ -203,11 +203,6 @@ WebInspector.ProjectStore.prototype = {
this._project._removeFile(path);
},
- reset: function()
- {
- this._project._reset();
- },
-
/**
* @return {!WebInspector.Project}
*/
@@ -304,9 +299,9 @@ WebInspector.Project.prototype = {
this._workspace.dispatchEventToListeners(WebInspector.Workspace.Events.UISourceCodeRemoved, entry.uiSourceCode);
},
- _reset: function()
+ _remove: function()
{
- this._workspace.dispatchEventToListeners(WebInspector.Workspace.Events.ProjectWillReset, this);
+ this._workspace.dispatchEventToListeners(WebInspector.Workspace.Events.ProjectRemoved, this);
this._uiSourceCodesMap = {};
this._uiSourceCodesList = [];
},
@@ -553,7 +548,7 @@ WebInspector.Workspace.Events = {
UISourceCodeAdded: "UISourceCodeAdded",
UISourceCodeRemoved: "UISourceCodeRemoved",
UISourceCodeContentCommitted: "UISourceCodeContentCommitted",
- ProjectWillReset: "ProjectWillReset"
+ ProjectRemoved: "ProjectRemoved"
}
WebInspector.Workspace.prototype = {
@@ -633,8 +628,8 @@ WebInspector.Workspace.prototype = {
var project = this._projects[projectId];
if (!project)
return;
- project._reset();
delete this._projects[projectId];
+ project._remove();
},
/**

Powered by Google App Engine
This is Rietveld 408576698