Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1701)

Unified Diff: Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js

Issue 313603003: Devtools: get rid of ProjectWillReset event, introduce ProjectRemoved instead of it (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js
diff --git a/Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js b/Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js
index f39393cc679d09a4dc799ed61813635ffb113824..528c31d8a6da6e60adb57fe83bb7c2f63ff02ab5 100644
--- a/Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js
+++ b/Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js
@@ -40,6 +40,8 @@ WebInspector.ContentProviderBasedProjectDelegate = function(workspace, id, type)
this._type = type;
/** @type {!Object.<string, !WebInspector.ContentProvider>} */
this._contentProviders = {};
+ this._workspace = workspace;
+ this._id = id;
this._projectStore = workspace.addProject(id, this);
}
@@ -334,6 +336,7 @@ WebInspector.ContentProviderBasedProjectDelegate.prototype = {
reset: function()
{
this._contentProviders = {};
- this._projectStore.reset();
+ this._workspace.removeProject(this._id);
+ this._projectStore = this._workspace.addProject(this._id, this);
vsevik 2014/06/04 06:04:50 Looks like there are cases when we addProject with
}
}

Powered by Google App Engine
This is Rietveld 408576698