Issue 313603003: Devtools: get rid of ProjectWillReset event, introduce ProjectRemoved instead of it

Issue 313603003: Devtools: get rid of ProjectWillReset event, introduce ProjectRemoved instead of it (Closed)

Created:
6 years, 6 months ago by sergeyv

Modified:
6 years, 6 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Devtools: get rid of ProjectWillReset event, introduce ProjectRemoved instead of it BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175451

Patch Set 1 #

Total comments: 2

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+47 lines, -66 lines)			Patch
M	LayoutTests/inspector/snippet-storage.html	View	1 chunk	+0 lines, -1 line	1 comment	Download
M	LayoutTests/inspector/sources/debugger/file-system-project-mapping.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	LayoutTests/inspector/sources/debugger/file-system-project-mapping-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/inspector/sources/debugger/script-snippet-model.html	View	6 chunks	+20 lines, -19 lines	0 comments	Download
M	Source/devtools/front_end/sdk/BreakpointManager.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sdk/ContentProviderBasedProjectDelegate.js	View	2 chunks	+4 lines, -1 line	1 comment	Download
M	Source/devtools/front_end/sdk/SASSSourceMapping.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/sdk/ScriptSnippetModel.js	View	2 chunks	+1 line, -11 lines	0 comments	Download
M	Source/devtools/front_end/sdk/SnippetStorage.js	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	Source/devtools/front_end/sdk/StylesSourceMapping.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sdk/Workspace.js	View	4 chunks	+4 lines, -9 lines	0 comments	Download
M	Source/devtools/front_end/sources/FilteredItemSelectionDialog.js	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/sources/NavigatorView.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sources/RevisionHistoryView.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/devtools/front_end/sources/SourcesView.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://codereview.chromium.org/313603003/diff/1/LayoutTests/inspector/snippet-storage.html File LayoutTests/inspector/snippet-storage.html (left): https://codereview.chromium.org/313603003/diff/1/LayoutTests/inspector/snippet-storage.html#oldcode10 LayoutTests/inspector/snippet-storage.html:10: snippetStorage.reset(); Do you really need to remove this? ...

6 years, 6 months ago (2014-06-04 06:04:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/313603003/1

6 years, 6 months ago (2014-06-04 06:05:24 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...

6 years, 6 months ago (2014-06-04 07:24:37 UTC) #4

Message was sent while issue was closed.

Change committed as 175451

Expand Messages | Collapse Messages