Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 313603002: Let benchmark runner exit with proper return codes. (Closed)

Created:
6 years, 6 months ago by Michael Achenbach
Modified:
6 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Let benchmark runner exit with proper return codes. BUG=374740 LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M tools/run_benchmarks.py View 2 chunks +3 lines, -1 line 0 comments Download
M tools/unittests/run_benchmarks_test.py View 7 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Achenbach
PTAL
6 years, 6 months ago (2014-06-03 14:34:28 UTC) #1
Jakob Kummerow
lgtm
6 years, 6 months ago (2014-06-03 14:54:39 UTC) #2
Michael Achenbach
6 years, 6 months ago (2014-06-03 14:59:12 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21648 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698