Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1107)

Unified Diff: tools/run_benchmarks.py

Issue 313603002: Let benchmark runner exit with proper return codes. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/unittests/run_benchmarks_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run_benchmarks.py
diff --git a/tools/run_benchmarks.py b/tools/run_benchmarks.py
index 42b5bf5b86892c69fad7f141975609be588245c3..1a07025f07d61a9890bfd146625e982fb8f340f0 100755
--- a/tools/run_benchmarks.py
+++ b/tools/run_benchmarks.py
@@ -345,7 +345,7 @@ def Main(args):
if not options.arch in SUPPORTED_ARCHS: # pragma: no cover
print "Unknown architecture %s" % options.arch
- return False
+ return 1
workspace = os.path.abspath(os.path.join(os.path.dirname(__file__), ".."))
@@ -395,5 +395,7 @@ def Main(args):
else: # pragma: no cover
print results
+ return min(1, len(results.errors))
+
if __name__ == "__main__": # pragma: no cover
sys.exit(Main(sys.argv[1:]))
« no previous file with comments | « no previous file | tools/unittests/run_benchmarks_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698