Issue 3136017: Add additional sanity checks to RSA verification code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3136017: Add additional sanity checks to RSA verification code. (Closed)

Created:
10 years, 4 months ago by gauravsh

Modified:
9 years, 6 months ago

Reviewers:
Randall Spangler

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Luigi Semenzato, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Description

Add additional sanity checks to RSA verification code. Also, make algorithm unsigned int in most places. BUG=chrome-os-partner:701 TEST=existing RSA verification tests still pass

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -37 lines)			Patch
M	firmware/lib/cryptolib/include/rsa.h	View	3 chunks	+9 lines, -6 lines	0 comments	Download
M	firmware/lib/cryptolib/rsa.c	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	firmware/lib/cryptolib/rsa_utility.c	View	7 chunks	+26 lines, -12 lines	0 comments	Download
M	firmware/lib/vboot_common.c	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	firmware/version.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	host/include/file_keys.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	host/include/signature_digest.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	host/lib/file_keys.c	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	host/lib/host_key.c	View	7 chunks	+7 lines, -7 lines	0 comments	Download
M	host/lib/signature_digest.c	View	3 chunks	+4 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages