firmware/lib/cryptolib/rsa.c - Issue 3136017: Add additional sanity checks to RSA verification code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: firmware/lib/cryptolib/rsa.c

Issue 3136017: Add additional sanity checks to RSA verification code. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: firmware/lib/cryptolib/rsa.c

diff --git a/firmware/lib/cryptolib/rsa.c b/firmware/lib/cryptolib/rsa.c

index adc0dc0513fccd8a386a5cfa3549552d447add34..bad01d835d775c541de5ee1d631288d157aa8757 100644

--- a/firmware/lib/cryptolib/rsa.c

+++ b/firmware/lib/cryptolib/rsa.c

@@ -134,6 +134,9 @@ int RSAVerify(const RSAPublicKey *key,

const uint8_t* padding;

int success = 1;

+ if (!key || !sig || !hash)

+ return 0;

if (sig_len != (key->len * sizeof(uint32_t))) {

VBDEBUG(("Signature is of incorrect length!\n"));

return 0;

« no previous file with comments | « firmware/lib/cryptolib/include/rsa.h ('k') | firmware/lib/cryptolib/rsa_utility.c » ('j') | no next file with comments »