Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2424)

Unified Diff: chrome/browser/ui/webui/uber/uber_ui.cc

Issue 313363004: Separate Settings and Help from History and Extensions when settings-in- (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase (no conflicts) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/settings_window_manager_browsertest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/uber/uber_ui.cc
diff --git a/chrome/browser/ui/webui/uber/uber_ui.cc b/chrome/browser/ui/webui/uber/uber_ui.cc
index 9e2507999fb25ebbb2d56a3aabfae4fa032e3971..6fb3577bd6d9b8900ecea682bb10e3e3773275a1 100644
--- a/chrome/browser/ui/webui/uber/uber_ui.cc
+++ b/chrome/browser/ui/webui/uber/uber_ui.cc
@@ -4,6 +4,7 @@
#include "chrome/browser/ui/webui/uber/uber_ui.h"
+#include "base/command_line.h"
#include "base/stl_util.h"
#include "base/strings/utf_string_conversions.h"
#include "chrome/browser/chrome_notification_types.h"
@@ -12,6 +13,7 @@
#include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"
#include "chrome/browser/ui/webui/extensions/extensions_ui.h"
#include "chrome/browser/ui/webui/options/options_ui.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/manifest_url_handler.h"
#include "chrome/common/url_constants.h"
#include "content/public/browser/navigation_controller.h"
@@ -33,6 +35,11 @@ using content::WebContents;
namespace {
+bool IsSettingsWindowEnabled() {
+ return CommandLine::ForCurrentProcess()->HasSwitch(
+ ::switches::kEnableSettingsWindow);
+}
+
content::WebUIDataSource* CreateUberHTMLSource() {
content::WebUIDataSource* source =
content::WebUIDataSource::Create(chrome::kChromeUIUberHost);
@@ -102,19 +109,27 @@ content::WebUIDataSource* CreateUberFrameHTMLSource(Profile* profile) {
source->AddLocalizedString("shortProductName", IDS_SHORT_PRODUCT_NAME);
#endif // defined(OS_CHROMEOS)
+ // Group settings and help separately if settings in a window is enabled.
+ base::string16 settings_group(ASCIIToUTF16("settings_group"));
+ base::string16 other_group(ASCIIToUTF16(
+ IsSettingsWindowEnabled() ? "other_group" : "settings_group"));
source->AddString("extensionsHost",
ASCIIToUTF16(chrome::kChromeUIExtensionsHost));
source->AddLocalizedString("extensionsDisplayName",
IDS_MANAGE_EXTENSIONS_SETTING_WINDOWS_TITLE);
+ source->AddString("extensionsGroup", other_group);
source->AddString("helpHost",
ASCIIToUTF16(chrome::kChromeUIHelpHost));
source->AddLocalizedString("helpDisplayName", IDS_ABOUT_TITLE);
+ source->AddString("helpGroup", settings_group);
source->AddString("historyHost",
ASCIIToUTF16(chrome::kChromeUIHistoryHost));
source->AddLocalizedString("historyDisplayName", IDS_HISTORY_TITLE);
+ source->AddString("historyGroup", other_group);
source->AddString("settingsHost",
ASCIIToUTF16(chrome::kChromeUISettingsHost));
source->AddLocalizedString("settingsDisplayName", IDS_SETTINGS_TITLE);
+ source->AddString("settingsGroup", settings_group);
bool overridesHistory = HasExtensionType(profile,
chrome::kChromeUIHistoryHost);
source->AddString("overridesHistory",
« no previous file with comments | « chrome/browser/ui/settings_window_manager_browsertest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698