Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6112)

Unified Diff: chrome/browser/ui/settings_window_manager_browsertest.cc

Issue 313363004: Separate Settings and Help from History and Extensions when settings-in- (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase (no conflicts) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/settings_window_manager.h ('k') | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/settings_window_manager_browsertest.cc
diff --git a/chrome/browser/ui/settings_window_manager_browsertest.cc b/chrome/browser/ui/settings_window_manager_browsertest.cc
index a1f7d27de618e219547002dea6f47a490b965ed8..fdb756fb2727ac32492f87ad4853b247fe415d2e 100644
--- a/chrome/browser/ui/settings_window_manager_browsertest.cc
+++ b/chrome/browser/ui/settings_window_manager_browsertest.cc
@@ -183,29 +183,25 @@ IN_PROC_BROWSER_TEST_F(SettingsWindowManagerTest, SettingsWindowMultiProfile) {
}
#endif
-IN_PROC_BROWSER_TEST_F(SettingsWindowManagerTest, OpenSettingsChromePages) {
+IN_PROC_BROWSER_TEST_F(SettingsWindowManagerTest, OpenChromePages) {
+ EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
+
+ // History should open in the existing browser window.
+ chrome::ShowHistory(browser());
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
// Settings should open a new browser window.
chrome::ShowSettings(browser());
EXPECT_EQ(2u, chrome::GetTotalBrowserCount());
- // History should open a new browser window.
- CloseNonDefaultBrowsers();
- EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
- chrome::ShowHistory(browser());
- EXPECT_EQ(2u, chrome::GetTotalBrowserCount());
-
- // Extensions should open a new browser window.
+ // Extensions should open in an existing browser window.
CloseNonDefaultBrowsers();
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
std::string extension_to_highlight; // none
chrome::ShowExtensions(browser(), extension_to_highlight);
- EXPECT_EQ(2u, chrome::GetTotalBrowserCount());
-
- // Downloads should NOT open a new browser window.
- CloseNonDefaultBrowsers();
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
+
+ // Downloads should open in an existing browser window.
chrome::ShowDownloads(browser());
EXPECT_EQ(1u, chrome::GetTotalBrowserCount());
}
« no previous file with comments | « chrome/browser/ui/settings_window_manager.h ('k') | chrome/browser/ui/webui/uber/uber_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698