Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 313343003: reland "rebaseline_server: download actual-results.json files from GCS instead of SVN" (Closed)

Created:
6 years, 6 months ago by epoger
Modified:
6 years, 6 months ago
Reviewers:
jcgregorio
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

reland "rebaseline_server: download actual-results.json files from GCS instead of SVN" relands https://codereview.chromium.org/310093003 with modifications. BUG=skia:2641 Committed: https://skia.googlesource.com/skia/+/b144271179aaf82cb1151e9dfd8e866747402594

Patch Set 1 : original CL without modification #

Patch Set 2 : import apiclient from system-installed Python libraries, not DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+343 lines, -320 lines) Patch
M DEPS View 1 1 chunk +0 lines, -1 line 0 comments Download
M gm/rebaseline_server/compare_configs.py View 2 chunks +3 lines, -19 lines 0 comments Download
M gm/rebaseline_server/compare_rendered_pictures.py View 2 chunks +3 lines, -18 lines 0 comments Download
M gm/rebaseline_server/compare_to_expectations.py View 3 chunks +4 lines, -17 lines 0 comments Download
M gm/rebaseline_server/download_actuals.py View 3 chunks +12 lines, -117 lines 0 comments Download
M gm/rebaseline_server/download_actuals_test.py View 2 chunks +4 lines, -40 lines 0 comments Download
A gm/rebaseline_server/fix_pythonpath.py View 1 chunk +21 lines, -0 lines 0 comments Download
M gm/rebaseline_server/results.py View 2 chunks +2 lines, -11 lines 0 comments Download
M gm/rebaseline_server/server.py View 11 chunks +83 lines, -73 lines 0 comments Download
A + tools/pyutils/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/pyutils/gs_utils.py View 1 1 chunk +81 lines, -0 lines 0 comments Download
A tools/pyutils/url_utils.py View 1 chunk +63 lines, -0 lines 0 comments Download
A tools/pyutils/url_utils_test.py View 1 chunk +61 lines, -0 lines 0 comments Download
A + tools/test_all.py View 1 chunk +7 lines, -3 lines 0 comments Download
A + tools/tests/__init__.py View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/tests/run.sh View 1 chunk +1 line, -1 line 0 comments Download
D tools/tests/run_all.py View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
epoger
Joe- please review diffs between patchsets 1 and 2.
6 years, 6 months ago (2014-06-05 16:59:13 UTC) #1
jcgregorio
On 2014/06/05 16:59:13, epoger wrote: > Joe- please review diffs between patchsets 1 and 2. ...
6 years, 6 months ago (2014-06-05 17:01:26 UTC) #2
epoger
The CQ bit was checked by epoger@google.com
6 years, 6 months ago (2014-06-05 17:01:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/313343003/20001
6 years, 6 months ago (2014-06-05 17:02:10 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 17:30:42 UTC) #5
Message was sent while issue was closed.
Change committed as b144271179aaf82cb1151e9dfd8e866747402594

Powered by Google App Engine
This is Rietveld 408576698