Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 310093003: rebaseline_server: download actual-results.json files from GCS instead of SVN (Closed)

Created:
6 years, 6 months ago by epoger
Modified:
6 years, 6 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: download actual-results.json files from GCS instead of SVN BUG=skia:553 Committed: https://skia.googlesource.com/skia/+/f4666045f378dee22ce40108e90bf5195634ebfc

Patch Set 1 : share get_builders_list() function between download_actuals.py and server.py #

Patch Set 2 : remove --actuals-revision option #

Patch Set 3 : download actual-results.json files from GCS instead of SVN #

Total comments: 6

Patch Set 4 : extract gs_utils and url_utils into their own files #

Total comments: 6

Patch Set 5 : move gs_utils.py and url_utils.py into tools/pyutils #

Total comments: 2

Patch Set 6 : make url_utils_test get exercised #

Patch Set 7 : combine import_gm and import_tools into fix_pythonpath #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+344 lines, -319 lines) Patch
M gm/rebaseline_server/compare_configs.py View 1 2 3 4 5 6 2 chunks +3 lines, -19 lines 0 comments Download
M gm/rebaseline_server/compare_rendered_pictures.py View 1 2 3 4 5 6 2 chunks +3 lines, -18 lines 0 comments Download
M gm/rebaseline_server/compare_to_expectations.py View 1 2 3 4 5 6 3 chunks +4 lines, -17 lines 0 comments Download
M gm/rebaseline_server/download_actuals.py View 1 2 3 4 5 6 3 chunks +12 lines, -117 lines 0 comments Download
M gm/rebaseline_server/download_actuals_test.py View 1 2 3 4 5 6 2 chunks +4 lines, -40 lines 0 comments Download
A gm/rebaseline_server/fix_pythonpath.py View 1 2 3 4 5 6 1 chunk +21 lines, -0 lines 0 comments Download
M gm/rebaseline_server/results.py View 1 2 3 4 5 6 2 chunks +2 lines, -11 lines 0 comments Download
M gm/rebaseline_server/server.py View 1 2 3 4 5 6 11 chunks +83 lines, -73 lines 0 comments Download
A + tools/pyutils/__init__.py View 1 2 3 4 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/pyutils/gs_utils.py View 1 2 3 4 1 chunk +82 lines, -0 lines 0 comments Download
A tools/pyutils/url_utils.py View 1 2 3 4 1 chunk +63 lines, -0 lines 0 comments Download
A tools/pyutils/url_utils_test.py View 1 2 3 4 5 1 chunk +61 lines, -0 lines 2 comments Download
A + tools/test_all.py View 1 2 3 4 5 1 chunk +7 lines, -3 lines 0 comments Download
A + tools/tests/__init__.py View 1 2 3 4 5 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/tests/run.sh View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
D tools/tests/run_all.py View 1 2 3 4 5 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
epoger
Eric (or Ravi)- PTAL https://codereview.chromium.org/310093003/diff/40001/gm/rebaseline_server/download_actuals.py File gm/rebaseline_server/download_actuals.py (left): https://codereview.chromium.org/310093003/diff/40001/gm/rebaseline_server/download_actuals.py#oldcode109 gm/rebaseline_server/download_actuals.py:109: # we don't already have ...
6 years, 6 months ago (2014-06-03 20:11:03 UTC) #1
borenet
Looks mostly good, just a couple of comments/questions. https://codereview.chromium.org/310093003/diff/40001/gm/rebaseline_server/download_actuals.py File gm/rebaseline_server/download_actuals.py (right): https://codereview.chromium.org/310093003/diff/40001/gm/rebaseline_server/download_actuals.py#newcode167 gm/rebaseline_server/download_actuals.py:167: EPOGER: ...
6 years, 6 months ago (2014-06-03 20:27:47 UTC) #2
epoger
Thanks, Eric. Please grab me for live discussion of these issues when you have a ...
6 years, 6 months ago (2014-06-03 20:39:04 UTC) #3
epoger
Thanks, Eric. Please see patchset 4. https://codereview.chromium.org/310093003/diff/60001/gm/rebaseline_server/gs_utils.py File gm/rebaseline_server/gs_utils.py (right): https://codereview.chromium.org/310093003/diff/60001/gm/rebaseline_server/gs_utils.py#newcode11 gm/rebaseline_server/gs_utils.py:11: TODO(epoger): move this ...
6 years, 6 months ago (2014-06-03 21:43:20 UTC) #4
borenet
Looks good except I'm confused about copy_contents. https://codereview.chromium.org/310093003/diff/60001/gm/rebaseline_server/gs_utils.py File gm/rebaseline_server/gs_utils.py (right): https://codereview.chromium.org/310093003/diff/60001/gm/rebaseline_server/gs_utils.py#newcode11 gm/rebaseline_server/gs_utils.py:11: TODO(epoger): move ...
6 years, 6 months ago (2014-06-04 13:10:15 UTC) #5
epoger
Thanks, Eric... please see patchset 5. https://codereview.chromium.org/310093003/diff/60001/gm/rebaseline_server/gs_utils.py File gm/rebaseline_server/gs_utils.py (right): https://codereview.chromium.org/310093003/diff/60001/gm/rebaseline_server/gs_utils.py#newcode11 gm/rebaseline_server/gs_utils.py:11: TODO(epoger): move this ...
6 years, 6 months ago (2014-06-04 14:39:35 UTC) #6
borenet
LGTM with optional nit about the import_* modules. https://codereview.chromium.org/310093003/diff/60001/gm/rebaseline_server/url_utils.py File gm/rebaseline_server/url_utils.py (right): https://codereview.chromium.org/310093003/diff/60001/gm/rebaseline_server/url_utils.py#newcode58 gm/rebaseline_server/url_utils.py:58: dest_dir ...
6 years, 6 months ago (2014-06-04 15:04:52 UTC) #7
epoger
I think we're there... please see patchsets 6+7. https://codereview.chromium.org/310093003/diff/80001/gm/rebaseline_server/import_gm.py File gm/rebaseline_server/import_gm.py (right): https://codereview.chromium.org/310093003/diff/80001/gm/rebaseline_server/import_gm.py#newcode1 gm/rebaseline_server/import_gm.py:1: #!/usr/bin/python ...
6 years, 6 months ago (2014-06-04 15:20:36 UTC) #8
borenet
LGTM at patch set 7. https://codereview.chromium.org/310093003/diff/120001/tools/pyutils/url_utils_test.py File tools/pyutils/url_utils_test.py (right): https://codereview.chromium.org/310093003/diff/120001/tools/pyutils/url_utils_test.py#newcode23 tools/pyutils/url_utils_test.py:23: class UrlUtilsTest(unittest.TestCase): On 2014/06/04 ...
6 years, 6 months ago (2014-06-04 15:43:23 UTC) #9
epoger
The CQ bit was checked by epoger@google.com
6 years, 6 months ago (2014-06-04 16:51:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/310093003/120001
6 years, 6 months ago (2014-06-04 16:53:02 UTC) #11
commit-bot: I haz the power
Change committed as f4666045f378dee22ce40108e90bf5195634ebfc
6 years, 6 months ago (2014-06-04 17:03:03 UTC) #12
epoger
6 years, 6 months ago (2014-06-05 17:03:11 UTC) #13
Message was sent while issue was closed.
Reverted in https://codereview.chromium.org/317783004 , as a result of
http://skbug.com/2641 ('rebaseline_server: google-api-python-client requires
manually installed dependencies')

Powered by Google App Engine
This is Rietveld 408576698