Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 313303003: Remove dead neonDrawLighting code (Closed)

Created:
6 years, 6 months ago by Mostyn Bramley-Moore
Modified:
6 years, 6 months ago
CC:
blink-reviews, Rik, danakj, krit, jamesr, jbroman, pdr., rwlbuis, Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove dead neonDrawLighting code FELightingNEON.h's inline FELighting::platformApplyNeon() method refers to an extern neonDrawLighting symbol. This function is implemented in assembly in WebKit but does not exist in blink. This must then be dead code (otherwise there would have been complaints). The only reference to platformApplyNeon that I can find is an ifdef'ed call in FELighting::platformApply(), which is only enabled if the target supports NEON but not Thumb (which I guess must be very uncommon). BUG=381082 TEST=build with arm_neon=1 arm_thumb=0 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176365

Patch Set 1 #

Patch Set 2 : more dead code removal #

Patch Set 3 : remove FELightingNEON.h completely #

Patch Set 4 : remove unused ARM_TRADITIONAL macro #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -226 lines) Patch
M Source/platform/BUILD.gn View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/graphics/cpu/arm/filters/FELightingNEON.h View 1 2 1 chunk +0 lines, -203 lines 0 comments Download
M Source/platform/graphics/filters/FELighting.h View 1 2 3 chunks +0 lines, -6 lines 0 comments Download
M Source/platform/graphics/filters/FELighting.cpp View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M Source/wtf/CPU.h View 1 2 3 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Mostyn Bramley-Moore
@Stephen, sugoi1: PTAL.
6 years, 6 months ago (2014-06-05 09:58:47 UTC) #1
sugoi
On 2014/06/05 09:58:47, Mostyn Bramley-Moore wrote: > @Stephen, sugoi1: PTAL. This will require Stephen's approval, ...
6 years, 6 months ago (2014-06-05 11:42:55 UTC) #2
Mostyn Bramley-Moore
On 2014/06/05 11:42:55, sugoi wrote: > On 2014/06/05 09:58:47, Mostyn Bramley-Moore wrote: > > @Stephen, ...
6 years, 6 months ago (2014-06-05 12:29:59 UTC) #3
Mostyn Bramley-Moore
@senorblanco: *ping* I also realised that the ARM_TRADITIONAL macro was also now dead, so removed ...
6 years, 6 months ago (2014-06-16 07:15:45 UTC) #4
Stephen White
LGTM BTW, uploading a new patch does not automatically send an email to the reviewers. ...
6 years, 6 months ago (2014-06-16 13:58:01 UTC) #5
Mostyn Bramley-Moore
On 2014/06/16 13:58:01, Stephen White wrote: > LGTM Thanks. > BTW, uploading a new patch ...
6 years, 6 months ago (2014-06-16 18:50:37 UTC) #6
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 6 months ago (2014-06-16 18:50:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/313303003/60001
6 years, 6 months ago (2014-06-16 18:51:05 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 21:57:12 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7751)
6 years, 6 months ago (2014-06-16 21:57:13 UTC) #10
Mostyn Bramley-Moore
@jchaffraix: PTAL at the Source/wtf/CPU.h change.
6 years, 6 months ago (2014-06-17 00:27:12 UTC) #11
Julien - ping for review
wtf/ rslgtm
6 years, 6 months ago (2014-06-17 23:39:05 UTC) #12
commit-bot: I haz the power
6 years, 6 months ago (2014-06-17 23:43:37 UTC) #13
Message was sent while issue was closed.
Change committed as 176365

Powered by Google App Engine
This is Rietveld 408576698