Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 313243004: Roll gyp r1921:1927. (Closed)

Created:
6 years, 6 months ago by Torne
Modified:
6 years, 6 months ago
Reviewers:
bradnelson, bradn
CC:
chromium-reviews, gyp-developer_googlegroups.com
Visibility:
Public.

Description

Roll gyp r1921:1927. r1927 android: Handle inputs with spaces inside make functions. r1926 Fix msvs-ninja OutputDirectory path. r1925 msvs: Revert r1920 and add a test for excluded idl r1924 Use relative path/dir msbuild variables to map $(InputDir) and $(InputPath) r1923 Fix for some rules not being run if their trigger is also an action dependency r1922 ninja win: filter 64 bit idl processing, and confirm in test BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
Sending a gyp roll through the trybots to see what it looks like; I won't ...
6 years, 6 months ago (2014-06-05 09:42:04 UTC) #1
bradn
lgtm Seems to be back.
6 years, 6 months ago (2014-06-05 21:31:26 UTC) #2
Torne
The CQ bit was checked by torne@chromium.org
6 years, 6 months ago (2014-06-06 08:58:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/313243004/1
6 years, 6 months ago (2014-06-06 08:59:26 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 10:14:29 UTC) #5
Message was sent while issue was closed.
Change committed as 275368

Powered by Google App Engine
This is Rietveld 408576698