Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 313233005: Fix missing smi check in inlined indexOf/lastIndexOf. (Closed)

Created:
6 years, 6 months ago by Benedikt Meurer
Modified:
6 years, 6 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Fix missing smi check in inlined indexOf/lastIndexOf. BUG=382513 LOG=y R=danno@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21727

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M src/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + test/mjsunit/regress/regress-crbug-382513.js View 1 chunk +3 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
PTAL
6 years, 6 months ago (2014-06-10 04:19:46 UTC) #1
danno
lgtm
6 years, 6 months ago (2014-06-10 04:21:32 UTC) #2
Benedikt Meurer
6 years, 6 months ago (2014-06-10 04:26:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21727 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698