src/hydrogen.cc - Issue 313233005: Fix missing smi check in inlined indexOf/lastIndexOf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 313233005: Fix missing smi check in inlined indexOf/lastIndexOf. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 1e623afc81fa7eba25ecef8081b850efd70f672f..df83f040e49d9d7c237d2093332825c837d20324 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -8538,7 +8538,8 @@ HValue* HOptimizedGraphBuilder::BuildArrayIndexOf(HValue* receiver,

elements, index, static_cast<HValue*>(NULL),

kind, ALLOW_RETURN_HOLE);

IfBuilder if_issame(this);

- HCompareMap* issame = if_issame.If<HCompareMap>(

+ if_issame.IfNot<HIsSmiAndBranch>(element);

+ HCompareMap* issame = if_issame.AndIf<HCompareMap>(

element, isolate()->factory()->heap_number_map());

if_issame.And();

HValue* number = Add<HLoadNamedField>(

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-382513.js » ('j') | no next file with comments »