Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing.

Source/core/editing/CompositionUnderline.h

Index: Source/core/editing/CompositionUnderline.h
diff --git a/Source/core/editing/CompositionUnderline.h b/Source/core/editing/CompositionUnderline.h
index 025ee75cbf7696170769d5531c0891a254fb2681..d093469d4152e1b22c07f9252a5941d3b3c481a5 100644
--- a/Source/core/editing/CompositionUnderline.h
+++ b/Source/core/editing/CompositionUnderline.h
@@ -32,13 +32,32 @@ namespace WebCore {
 
 struct CompositionUnderline {
     CompositionUnderline()
-        : startOffset(0), endOffset(0), thick(false) { }
+        : startOffset(0)
+        , endOffset(0)
+        , color(0)
+        , thick(false)
+        , backgroundColor(0) { }

[tkent, 2014/06/13 04:31:42]

0 Color is not good for readability.
, backgroundColor(Color::transparent) { }

or omit backgroundColor initialization.  Color has the default constructor with
no arguments.

[huangs, 2014/06/13 17:22:24]

Done.

+
+    // TODO(huangs): remove this constructor.

[tkent, 2014/06/13 04:31:42]

Use FIXME: instead of TODO(name).

[huangs, 2014/06/13 17:22:24]

Done.

     CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t)
-        : startOffset(s), endOffset(e), color(c), thick(t) { }
+        : startOffset(s)
+        , endOffset(e)
+        , color(c)
+        , thick(t)
+        , backgroundColor(0) { }

[tkent, 2014/06/13 04:31:43]

0 Color is not good.

[huangs, 2014/06/13 17:22:24]

Done.

+
+    CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t, const Color& bc)
+        : startOffset(s)
+        , endOffset(e)
+        , color(c)
+        , thick(t)
+        , backgroundColor(bc) { }
+
     unsigned startOffset;
     unsigned endOffset;
     Color color;
     bool thick;
+    Color backgroundColor;
 };
 
 } // namespace WebCore