Source/core/editing/CompositionUnderline.h - Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing.

Side by Side Diff: Source/core/editing/CompositionUnderline.h

Issue 313233002: Adding backgroundColor to WebCompositionUnderline and using it for InlineTextBox drawing. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removing over-eager cleanups; adding CompositionUnderlineRangeFilter::operator->(). Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 14 matching lines...) Expand all Loading...
25	25

26 #ifndef CompositionUnderline_h	26 #ifndef CompositionUnderline_h

27 #define CompositionUnderline_h	27 #define CompositionUnderline_h

28	28

29 #include "platform/graphics/Color.h"	29 #include "platform/graphics/Color.h"

30	30

31 namespace WebCore {	31 namespace WebCore {

32	32

33 struct CompositionUnderline {	33 struct CompositionUnderline {

34 CompositionUnderline()	34 CompositionUnderline()

35 : startOffset(0), endOffset(0), thick(false) { }	35 : startOffset(0)

	36 , endOffset(0)

	37 , color(0)

	38 , thick(false)

	39 , backgroundColor(0) { }
	tkent 2014/06/13 04:31:42 0 Color is not good for readability. , backgroundC 0 Color is not good for readability. , backgroundColor(Color::transparent) { } or omit backgroundColor initialization. Color has the default constructor with no arguments. huangs 2014/06/13 17:22:24 Done. Show quoted text On 2014/06/13 04:31:42, tkent wrote: > 0 Color is not good for readability. > , backgroundColor(Color::transparent) { } > > or omit backgroundColor initialization. Color has the default constructor with > no arguments. Done.
	40

	41 // TODO(huangs): remove this constructor.
	tkent 2014/06/13 04:31:42 Use FIXME: instead of TODO(name). Use FIXME: instead of TODO(name). huangs 2014/06/13 17:22:24 Done. Show quoted text On 2014/06/13 04:31:42, tkent wrote: > Use FIXME: instead of TODO(name). Done.
36 CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t)	42 CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t)

37 : startOffset(s), endOffset(e), color(c), thick(t) { }	43 : startOffset(s)

	44 , endOffset(e)

	45 , color(c)

	46 , thick(t)

	47 , backgroundColor(0) { }
	tkent 2014/06/13 04:31:43 0 Color is not good. 0 Color is not good. huangs 2014/06/13 17:22:24 Done. Show quoted text On 2014/06/13 04:31:43, tkent wrote: > 0 Color is not good. Done.
	48

	49 CompositionUnderline(unsigned s, unsigned e, const Color& c, bool t, const C olor& bc)

	50 : startOffset(s)

	51 , endOffset(e)

	52 , color(c)

	53 , thick(t)

	54 , backgroundColor(bc) { }

	55

38 unsigned startOffset;	56 unsigned startOffset;

39 unsigned endOffset;	57 unsigned endOffset;

40 Color color;	58 Color color;

41 bool thick;	59 bool thick;

	60 Color backgroundColor;

42 };	61 };

43	62

44 } // namespace WebCore	63 } // namespace WebCore

45	64

46 #endif // CompositionUnderline_h	65 #endif // CompositionUnderline_h

OLD	NEW

« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/editing/CompositionUnderlineRangeFilter.h » ('j') | Source/core/editing/CompositionUnderlineRangeFilter.h » ('J')