chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h - Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master for CQ Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

index bebb6137cbec09c6b3112d7e5489429f16ed1475..2b403a10360a55c55e2a4d1bbc8d84438ee93174 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h

@@ -10,7 +10,7 @@

#import <Cocoa/Cocoa.h>

#include "base/mac/scoped_nsobject.h"

-#include "base/memory/scoped_ptr.h"

+#include "base/memory/ref_counted.h"

#include "base/strings/string16.h"

#include "chrome/browser/extensions/extension_install_prompt.h"

#include "ui/gfx/image/image_skia.h"

@@ -43,7 +43,7 @@ class PageNavigator;

content::PageNavigator* navigator_; // weak

ExtensionInstallPrompt::Delegate* delegate_; // weak

- scoped_ptr<ExtensionInstallPrompt::Prompt> prompt_;

+ scoped_refptr<ExtensionInstallPrompt::Prompt> prompt_;

base::scoped_nsobject<NSArray> warnings_;

BOOL isComputingRowHeight_;

@@ -64,7 +64,7 @@ class PageNavigator;

- (id)initWithNavigator:(content::PageNavigator*)navigator

delegate:(ExtensionInstallPrompt::Delegate*)delegate

- prompt:(const ExtensionInstallPrompt::Prompt&)prompt;

+ prompt:(scoped_refptr<ExtensionInstallPrompt::Prompt>)prompt;

- (IBAction)storeLinkClicked:(id)sender; // Callback for "View details" link.

- (IBAction)cancel:(id)sender;

- (IBAction)ok:(id)sender;