Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm

Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest master for CQ Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm b/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm
index a6cd778a0561af4100c3c10ae63254469be51f65..2433752115bfe000f0978588ff9d73439dc2190d 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.mm
@@ -71,20 +71,23 @@ gfx::Image LoadInstallPromptIcon() {
file_contents.length());
}
-ExtensionInstallPrompt::Prompt BuildExtensionInstallPrompt(
+scoped_refptr<ExtensionInstallPrompt::Prompt> BuildExtensionInstallPrompt(
Extension* extension) {
- ExtensionInstallPrompt::Prompt prompt(ExtensionInstallPrompt::INSTALL_PROMPT);
- prompt.set_extension(extension);
- prompt.set_icon(LoadInstallPromptIcon());
+ scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
+ new ExtensionInstallPrompt::Prompt(
+ ExtensionInstallPrompt::INSTALL_PROMPT);
+ prompt->set_extension(extension);
+ prompt->set_icon(LoadInstallPromptIcon());
return prompt;
}
-ExtensionInstallPrompt::Prompt BuildExtensionPostInstallPermissionsPrompt(
- Extension* extension) {
- ExtensionInstallPrompt::Prompt prompt(
- ExtensionInstallPrompt::POST_INSTALL_PERMISSIONS_PROMPT);
- prompt.set_extension(extension);
- prompt.set_icon(LoadInstallPromptIcon());
+scoped_refptr<ExtensionInstallPrompt::Prompt>
+BuildExtensionPostInstallPermissionsPrompt(Extension* extension) {
+ scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
+ new ExtensionInstallPrompt::Prompt(
+ ExtensionInstallPrompt::POST_INSTALL_PERMISSIONS_PROMPT);
+ prompt->set_extension(extension);
+ prompt->set_icon(LoadInstallPromptIcon());
return prompt;
}

Powered by Google App Engine
This is Rietveld 408576698