chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm - Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Latest master for CQ Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller.mm ('k') | chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

index 4053c75639f4402edf69c07675bb6a9d58f2f652..d458b0e291cf9b6bf22ade5776ee2683310ada3b 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

@@ -31,7 +31,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, BasicTest) {

ExtensionInstallPrompt::ShowParams show_params(tab);

chrome::MockExtensionInstallPromptDelegate delegate;

- ExtensionInstallPrompt::Prompt prompt =

+ scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =

chrome::BuildExtensionInstallPrompt(extension_.get());

ExtensionInstallDialogController* controller =

@@ -56,7 +56,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest,

ExtensionInstallPrompt::ShowParams show_params(tab);

chrome::MockExtensionInstallPromptDelegate delegate;

- ExtensionInstallPrompt::Prompt prompt =

+ scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =

chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get());

ExtensionInstallDialogController* controller =