Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_browsertest.mm

Issue 313203004: Make ExtensionInstallPrompt::Prompt ref-counted (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Latest master for CQ Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller. h" 5 #import "chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller. h"
6 6
7 #include "chrome/browser/ui/browser.h" 7 #include "chrome/browser/ui/browser.h"
8 #include "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_co ntroller.h" 8 #include "chrome/browser/ui/cocoa/constrained_window/constrained_window_sheet_co ntroller.h"
9 #import "chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils. h" 9 #import "chrome/browser/ui/cocoa/extensions/extension_install_prompt_test_utils. h"
10 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h" 10 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
(...skipping 13 matching lines...) Expand all
24 24
25 protected: 25 protected:
26 scoped_refptr<Extension> extension_; 26 scoped_refptr<Extension> extension_;
27 }; 27 };
28 28
29 IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, BasicTest) { 29 IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, BasicTest) {
30 content::WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0); 30 content::WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0);
31 ExtensionInstallPrompt::ShowParams show_params(tab); 31 ExtensionInstallPrompt::ShowParams show_params(tab);
32 32
33 chrome::MockExtensionInstallPromptDelegate delegate; 33 chrome::MockExtensionInstallPromptDelegate delegate;
34 ExtensionInstallPrompt::Prompt prompt = 34 scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
35 chrome::BuildExtensionInstallPrompt(extension_.get()); 35 chrome::BuildExtensionInstallPrompt(extension_.get());
36 36
37 ExtensionInstallDialogController* controller = 37 ExtensionInstallDialogController* controller =
38 new ExtensionInstallDialogController(show_params, 38 new ExtensionInstallDialogController(show_params,
39 &delegate, 39 &delegate,
40 prompt); 40 prompt);
41 41
42 base::scoped_nsobject<NSWindow> window( 42 base::scoped_nsobject<NSWindow> window(
43 [[[controller->view_controller() view] window] retain]); 43 [[[controller->view_controller() view] window] retain]);
44 EXPECT_TRUE([window isVisible]); 44 EXPECT_TRUE([window isVisible]);
45 45
46 // Press cancel to close the window 46 // Press cancel to close the window
47 [[controller->view_controller() cancelButton] performClick:nil]; 47 [[controller->view_controller() cancelButton] performClick:nil];
48 48
49 // Wait for the window to finish closing. 49 // Wait for the window to finish closing.
50 EXPECT_FALSE([window isVisible]); 50 EXPECT_FALSE([window isVisible]);
51 } 51 }
52 52
53 IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest, 53 IN_PROC_BROWSER_TEST_F(ExtensionInstallDialogControllerTest,
54 DISABLED_Permissions) { 54 DISABLED_Permissions) {
55 content::WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0); 55 content::WebContents* tab = browser()->tab_strip_model()->GetWebContentsAt(0);
56 ExtensionInstallPrompt::ShowParams show_params(tab); 56 ExtensionInstallPrompt::ShowParams show_params(tab);
57 57
58 chrome::MockExtensionInstallPromptDelegate delegate; 58 chrome::MockExtensionInstallPromptDelegate delegate;
59 ExtensionInstallPrompt::Prompt prompt = 59 scoped_refptr<ExtensionInstallPrompt::Prompt> prompt =
60 chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get()); 60 chrome::BuildExtensionPostInstallPermissionsPrompt(extension_.get());
61 61
62 ExtensionInstallDialogController* controller = 62 ExtensionInstallDialogController* controller =
63 new ExtensionInstallDialogController(show_params, 63 new ExtensionInstallDialogController(show_params,
64 &delegate, 64 &delegate,
65 prompt); 65 prompt);
66 66
67 base::scoped_nsobject<NSWindow> window( 67 base::scoped_nsobject<NSWindow> window(
68 [[[controller->view_controller() view] window] retain]); 68 [[[controller->view_controller() view] window] retain]);
69 EXPECT_TRUE([window isVisible]); 69 EXPECT_TRUE([window isVisible]);
70 70
71 // Press cancel to close the window 71 // Press cancel to close the window
72 [[controller->view_controller() cancelButton] performClick:nil]; 72 [[controller->view_controller() cancelButton] performClick:nil];
73 73
74 // Wait for the window to finish closing. 74 // Wait for the window to finish closing.
75 EXPECT_FALSE([window isVisible]); 75 EXPECT_FALSE([window isVisible]);
76 } 76 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698