Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_arm.cc
===================================================================
--- runtime/vm/flow_graph_compiler_arm.cc (revision 36956)
+++ runtime/vm/flow_graph_compiler_arm.cc (working copy)
@@ -1236,19 +1236,10 @@
ASSERT(!arguments_descriptor.IsNull() && (arguments_descriptor.Length() > 0));
const MegamorphicCache& cache =
MegamorphicCache::ZoneHandle(table->Lookup(name, arguments_descriptor));
- Label not_smi, load_cache;
__ LoadFromOffset(kWord, R0, SP, (argument_count - 1) * kWordSize);
- __ tst(R0, Operand(kSmiTagMask));
- __ b(&not_smi, NE);
- __ mov(R0, Operand(Smi::RawValue(kSmiCid)));
- __ b(&load_cache);
+ __ LoadTaggedClassIdMayBeSmi(R0, R0);
- __ Bind(&not_smi);
- __ LoadClassId(R0, R0);
- __ SmiTag(R0);
-
// R0: class ID of the receiver (smi).
- __ Bind(&load_cache);
__ LoadObject(R1, cache);
__ ldr(R2, FieldAddress(R1, MegamorphicCache::buckets_offset()));
__ ldr(R1, FieldAddress(R1, MegamorphicCache::mask_offset()));

Powered by Google App Engine
This is Rietveld 408576698