Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1240)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 313083008: Add LoadTaggedClassIdMayBeSmi to assembly and improve performance of inline cache stubs. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/assembler_arm.cc
===================================================================
--- runtime/vm/assembler_arm.cc (revision 36956)
+++ runtime/vm/assembler_arm.cc (working copy)
@@ -1685,6 +1685,19 @@
}
+void Assembler::LoadTaggedClassIdMayBeSmi(Register result, Register object) {
zra 2014/06/04 18:55:00 tst(object, Operand(kSmiTagMask)); LoadImmediate(r
srdjan 2014/06/04 20:08:04 Done and added condition to LoadClassId
+ Label load, done;
+ tst(object, Operand(kSmiTagMask));
+ b(&load, NE);
+ LoadImmediate(result, Smi::RawValue(kSmiCid));
+ b(&done);
+ Bind(&load);
+ LoadClassId(result, object);
+ SmiTag(result);
+ Bind(&done);
+}
+
+
static bool CanEncodeBranchOffset(int32_t offset) {
ASSERT(Utils::IsAligned(offset, 4));
return Utils::IsInt(Utils::CountOneBits(kBranchOffsetMask), offset);

Powered by Google App Engine
This is Rietveld 408576698