Clean-up coding style

Clean-up coding style

BUG=
R=shess@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275391

[jaekyeom, 2014-06-04 07:39:36]

Please review these changes.

[Scott Hess - ex-Googler, 2014-06-04 16:19:08]

https://codereview.chromium.org/313073002/diff/1/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/313073002/diff/1/AUTHORS#newcode150
AUTHORS:150: Jaekyeom Kim <btapiz@gmail.com>
I see you in the CLA list, great!

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/client_side_detection_host.cc (right):

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/client_side_detection_host.cc:48: const int
ClientSideDetectionHost::kMaxIPsPerBrowse = 200;
Perhaps just make these size_t here and in the header?

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/malware_details_cache.cc (right):

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/malware_details_cache.cc:70: if (resources_it_ ==
resources_->end()) {  // We are done.
Or just remove the comment.  Being at the end and calling "AllDone(true)" seems
to imply that things are done.

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/prefix_set.cc (right):

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/prefix_set.cc:7: #include <math.h>
Is math.h even necessary?  I don't see anything obvious that needs it.

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/prefix_set_unittest.cc (right):

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/prefix_set_unittest.cc:11: #include <utility>
You already added utility to prefix_set.h.

[jaekyeom, 2014-06-05 11:58:56]

Thank you for the review. Please take another look.

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/client_side_detection_host.cc (right):

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/client_side_detection_host.cc:48: const int
ClientSideDetectionHost::kMaxIPsPerBrowse = 200;
On 2014/06/04 16:19:08, shess wrote:
> Perhaps just make these size_t here and in the header?

Done.

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/malware_details_cache.cc (right):

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/malware_details_cache.cc:70: if (resources_it_ ==
resources_->end()) {  // We are done.
On 2014/06/04 16:19:08, shess wrote:
> Or just remove the comment.  Being at the end and calling "AllDone(true)"
seems
> to imply that things are done.

Done.

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/prefix_set.cc (right):

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/prefix_set.cc:7: #include <math.h>
On 2014/06/04 16:19:08, shess wrote:
> Is math.h even necessary?  I don't see anything obvious that needs it.

Done.

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
File chrome/browser/safe_browsing/prefix_set_unittest.cc (right):

https://codereview.chromium.org/313073002/diff/1/chrome/browser/safe_browsing...
chrome/browser/safe_browsing/prefix_set_unittest.cc:11: #include <utility>
On 2014/06/04 16:19:08, shess wrote:
> You already added utility to prefix_set.h.

Done.

[Scott Hess - ex-Googler, 2014-06-05 17:47:54]

lgtm.

Let me know if you want me to click the c-q button.  You can generally feel free
to ask reviewers to do that as part of the review request (like not in the
check-in text, but in the email requesting review).

[jaekyeom, 2014-06-05 23:28:48]

The CQ bit was checked by btapiz@gmail.com

[jaekyeom, 2014-06-05 23:28:49]

The CQ bit was unchecked by btapiz@gmail.com

[jaekyeom, 2014-06-05 23:32:29]

The CQ bit was checked by btapiz@gmail.com

[commit-bot: I haz the power, 2014-06-05 23:34:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/btapiz@gmail.com/313073002/20001

[jaekyeom, 2014-06-05 23:36:19]

On 2014/06/05 17:47:54, shess wrote:
> lgtm.
> 
> Let me know if you want me to click the c-q button.  You can generally feel
free
> to ask reviewers to do that as part of the review request (like not in the
> check-in text, but in the email requesting review).

Thanks for your guidance! I checked it this time.

[jaekyeom, 2014-06-06 00:03:58]

The CQ bit was unchecked by btapiz@gmail.com

[jaekyeom, 2014-06-06 00:07:12]

The CQ bit was checked by btapiz@gmail.com

[commit-bot: I haz the power, 2014-06-06 00:08:52]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/btapiz@gmail.com/313073002/20001

[jaekyeom, 2014-06-06 00:17:34]

The CQ bit was unchecked by btapiz@gmail.com

[jaekyeom, 2014-06-06 03:33:17]

I rebased my branch in order to make the change on AUTHORS applicable.
Please take a look.
Also, could you push this into the commit queue if this looks good to you?

[Scott Hess - ex-Googler, 2014-06-06 03:57:04]

lgtm

[commit-bot: I haz the power, 2014-06-06 07:57:17]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)

[commit-bot: I haz the power, 2014-06-06 10:56:27]

Change committed as 275391