Clean-up coding style

chrome/browser/safe_browsing/client_side_detection_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/safe_browsing/client_side_detection_host.h"
 
 #include <vector>
 
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
@@ skipping 27 matching lines @@
 #include "url/gurl.h"
 
 using content::BrowserThread;
 using content::NavigationEntry;
 using content::ResourceRequestDetails;
 using content::WebContents;
 
 namespace safe_browsing {
 
 const int ClientSideDetectionHost::kMaxUrlsPerIP = 20;
 const int ClientSideDetectionHost::kMaxIPsPerBrowse = 200;

[Scott Hess - ex-Googler, 2014/06/04 16:19:08]

Perhaps just make these size_t here and in the header?

[jaekyeom, 2014/06/05 11:58:57]

Done.

 
 const char kSafeBrowsingMatchKey[] = "safe_browsing_match";
 
 typedef base::Callback<void(bool)> ShouldClassifyUrlCallback;
 
 // This class is instantiated each time a new toplevel URL loads, and
 // asynchronously checks whether the malware and phishing classifiers should run
 // for this URL.  If so, it notifies the host class by calling the provided
 // callback form the UI thread.  Objects of this class are ref-counted and will
 // be destroyed once nobody uses it anymore.  If |web_contents|, |csd_service|
@@ skipping 622 matching lines @@
     const std::string& ip,
     const std::string& url,
     const std::string& method,
     const std::string& referrer,
     const ResourceType::Type resource_type) {
   if (ip.empty() || url.empty())
     return;
 
   IPUrlMap::iterator it = browse_info_->ips.find(ip);
   if (it == browse_info_->ips.end()) {
-    if (int(browse_info_->ips.size()) < kMaxIPsPerBrowse) {
+    if (static_cast<int>(browse_info_->ips.size()) < kMaxIPsPerBrowse) {
       std::vector<IPUrlInfo> url_infos;
       url_infos.push_back(IPUrlInfo(url, method, referrer, resource_type));
       browse_info_->ips.insert(make_pair(ip, url_infos));
     }
-  } else if (int(it->second.size()) < kMaxUrlsPerIP) {
+  } else if (static_cast<int>(it->second.size()) < kMaxUrlsPerIP) {
     it->second.push_back(IPUrlInfo(url, method, referrer, resource_type));
   }
 }
 
 void ClientSideDetectionHost::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   DCHECK_EQ(type, content::NOTIFICATION_RESOURCE_RESPONSE_STARTED);
@@ skipping 30 matching lines @@
     ui_manager_->RemoveObserver(this);
 
   ui_manager_ = ui_manager;
   if (ui_manager)
     ui_manager_->AddObserver(this);
 
   database_manager_ = database_manager;
 }
 
 }  // namespace safe_browsing