Oilpan: Replace RefPtr to Node in MutationObserver-related classes with Oilpan transition types.

Oilpan: Replace RefPtr to Node in MutationObserver-related classes with Oilpan transition types.

BUG=357163
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175474

[tkent, 2014-06-04 07:21:30]

Please take a look at this.

[haraken, 2014-06-04 07:25:33]

LGTM

https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
File Source/core/dom/MutationObserverRegistration.h (right):

https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
Source/core/dom/MutationObserverRegistration.h:75: OwnPtr<NodeHashSet>
m_transientRegistrationNodes;

This should be OwnPtrWillBeMember<NodeHashSet>.

OwnPtr<WillBeHeapHashSet> doesn't cause a compile error (by accident) because we
allow trace(OwnPtr) for other reasons...

[sof, 2014-06-04 07:26:22]

https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
File Source/core/dom/MutationObserverRegistration.h (right):

https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
Source/core/dom/MutationObserverRegistration.h:75: OwnPtr<NodeHashSet>
m_transientRegistrationNodes;
If we want to lazily instantiate the hash set, could this be
OwnPtrWillBeMember<> instead?

[zerny-chromium, 2014-06-04 07:45:59]

lgtm

https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
File Source/core/dom/MutationObserverRegistration.h (right):

https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
Source/core/dom/MutationObserverRegistration.h:75: OwnPtr<NodeHashSet>
m_transientRegistrationNodes;
I'm surprised that this does not trigger a compile-time error. It is never
allowed to have an OwnPtr to a heap allocated object. The exception is only that
we can trace off-heap objects in OwnPtrs.

I'll see if there is an error in the plugin code.

[zerny-chromium, 2014-06-04 08:37:44]

On 2014/06/04 07:45:59, zerny-chromium wrote:
> lgtm
> 
>
https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
> File Source/core/dom/MutationObserverRegistration.h (right):
> 
>
https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
> Source/core/dom/MutationObserverRegistration.h:75: OwnPtr<NodeHashSet>
> m_transientRegistrationNodes;
> I'm surprised that this does not trigger a compile-time error. It is never
> allowed to have an OwnPtr to a heap allocated object. The exception is only
that
> we can trace off-heap objects in OwnPtrs.
> 
> I'll see if there is an error in the plugin code.

This was an error in the plugin. A fix is uploaded at:
https://codereview.chromium.org/318623002

[tkent, 2014-06-04 09:20:23]

https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
File Source/core/dom/MutationObserverRegistration.h (right):

https://codereview.chromium.org/313023004/diff/1/Source/core/dom/MutationObse...
Source/core/dom/MutationObserverRegistration.h:75: OwnPtr<NodeHashSet>
m_transientRegistrationNodes;
On 2014/06/04 07:45:59, zerny-chromium wrote:
> I'm surprised that this does not trigger a compile-time error. It is never
> allowed to have an OwnPtr to a heap allocated object. The exception is only
that
> we can trace off-heap objects in OwnPtrs.
> 
> I'll see if there is an error in the plugin code.

Thank you for pointing this out.
Yeah, I missed it because it was compilable with enbale_oilpan=1.

[tkent, 2014-06-04 09:20:29]

The CQ bit was checked by tkent@chromium.org

[commit-bot: I haz the power, 2014-06-04 09:21:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/tkent@chromium.org/313023004/20001

[commit-bot: I haz the power, 2014-06-04 10:45:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)

[commit-bot: I haz the power, 2014-06-04 10:58:23]

Change committed as 175474