Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Issue 318623002: Blink GC plugin: disallow own pointers to GC allocated collections. (Closed)

Created:
6 years, 6 months ago by zerny-chromium
Modified:
6 years, 6 months ago
Reviewers:
haraken
CC:
chromium-reviews, oilpan-reviews
Visibility:
Public.

Description

Blink GC plugin: disallow own pointers to GC allocated collections. BUG=334149 R=haraken@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274816

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M tools/clang/blink_gc_plugin/BlinkGCPlugin.cpp View 3 chunks +7 lines, -2 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.h View 1 chunk +1 line, -0 lines 0 comments Download
M tools/clang/blink_gc_plugin/tests/own_ptr_to_gc_managed_class.txt View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
zerny-chromium
6 years, 6 months ago (2014-06-04 08:37:28 UTC) #1
haraken
LGTM, thanks for the quick fix!
6 years, 6 months ago (2014-06-04 08:47:31 UTC) #2
zerny-chromium
The CQ bit was checked by zerny@chromium.org
6 years, 6 months ago (2014-06-04 09:32:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zerny@chromium.org/318623002/1
6 years, 6 months ago (2014-06-04 09:34:09 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 14:08:04 UTC) #5
Message was sent while issue was closed.
Change committed as 274816

Powered by Google App Engine
This is Rietveld 408576698