Oilpan: Replace RefPtrs to Document in core/{accessibility,animation,fetch} with Oilpan transition …

Source/core/accessibility/AXObjectCache.cpp

Index: Source/core/accessibility/AXObjectCache.cpp
diff --git a/Source/core/accessibility/AXObjectCache.cpp b/Source/core/accessibility/AXObjectCache.cpp
index 19741771c362aaec0315be4e1ffbf9ae636079a2..98f6e29874d345f739cc50d2c13b3770dab06873 100644
--- a/Source/core/accessibility/AXObjectCache.cpp
+++ b/Source/core/accessibility/AXObjectCache.cpp
@@ -691,7 +691,7 @@ void AXObjectCache::childrenChanged(AXObject* obj)
 
 void AXObjectCache::notificationPostTimerFired(Timer<AXObjectCache>*)
 {
-    RefPtr<Document> protectorForCacheOwner(m_document);
+    RefPtrWillBeRawPtr<Document> protectorForCacheOwner(m_document);

[dmazzoni, 2014/06/04 06:27:26]

In this particular case, the RefPtr is purely there to protect m_document from
being destroyed due to losing all reference counts - post-Oilpan we won't need
this line at all. Is there a transitional type to indicate that, or does it
deserve a comment? Or are we just going to fix these individually?

[Mads Ager (chromium), 2014/06/04 06:30:13]

Yes, exactly, this just have to go when we can turn oilpan on by default.

Most of them are called protect*, so when we turn on oilpan we will run through
the code base looking for raw pointers called protect* and get rid of them. So
in order to not have the same comment all over the source base we are letting
the protect name be the comment for us. :)

[haraken, 2014/06/04 06:31:50]

You're right. We've discussed introducing RefPtrWillBeRemoved, adding a FIXME
etc, but we decided to leave RefPtrWillBeRawPtr as is, because it would be easy
to grep & remove these pointers when switching to oilpan.

Other examples we'll remove in post-oilpan is:

void foo(PassRefPtrWillBeRawPtr<X> prp) {
  RefPtrWillBeRawPtr<X> p = prp;
  ...;
}

[zerny-chromium, 2014/06/04 06:31:52]

The RefPtrWillBeRaw<T> protect(foo) is sufficient. After transitioning this will
become T* protect(foo) and we will remove it completely then. (I think clang
will give us an unused warning for code like that.)

 
     m_notificationPostTimer.stop();