Oilpan: Replace RefPtrs to Document in core/{accessibility,animation,fetch} with Oilpan transition …

Source/core/accessibility/AXObjectCache.cpp

 /*
  * Copyright (C) 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 673 matching lines @@
 void AXObjectCache::childrenChanged(AXObject* obj)
 {
     if (!obj)
         return;
 
     obj->childrenChanged();
 }
 
 void AXObjectCache::notificationPostTimerFired(Timer<AXObjectCache>*)
 {
-    RefPtr<Document> protectorForCacheOwner(m_document);
+    RefPtrWillBeRawPtr<Document> protectorForCacheOwner(m_document);

[dmazzoni, 2014/06/04 06:27:26]

In this particular case, the RefPtr is purely there to protect m_document from
being destroyed due to losing all reference counts - post-Oilpan we won't need
this line at all. Is there a transitional type to indicate that, or does it
deserve a comment? Or are we just going to fix these individually?

[Mads Ager (chromium), 2014/06/04 06:30:13]

Yes, exactly, this just have to go when we can turn oilpan on by default.

Most of them are called protect*, so when we turn on oilpan we will run through
the code base looking for raw pointers called protect* and get rid of them. So
in order to not have the same comment all over the source base we are letting
the protect name be the comment for us. :)

[haraken, 2014/06/04 06:31:50]

You're right. We've discussed introducing RefPtrWillBeRemoved, adding a FIXME
etc, but we decided to leave RefPtrWillBeRawPtr as is, because it would be easy
to grep & remove these pointers when switching to oilpan.

Other examples we'll remove in post-oilpan is:

void foo(PassRefPtrWillBeRawPtr<X> prp) {
  RefPtrWillBeRawPtr<X> p = prp;
  ...;
}

[zerny-chromium, 2014/06/04 06:31:52]

The RefPtrWillBeRaw<T> protect(foo) is sufficient. After transitioning this will
become T* protect(foo) and we will remove it completely then. (I think clang
will give us an unused warning for code like that.)

 
     m_notificationPostTimer.stop();
 
     unsigned i = 0, count = m_notificationsToPost.size();
     for (i = 0; i < count; ++i) {
         AXObject* obj = m_notificationsToPost[i].first.get();
         if (!obj->axObjectID())
             continue;
 
         if (!obj->axObjectCache())
@@ skipping 307 matching lines @@
 {
     postPlatformNotification(getOrCreate(scrollView), AXScrollPositionChanged);
 }
 
 void AXObjectCache::handleScrollPositionChanged(RenderObject* renderObject)
 {
     postPlatformNotification(getOrCreate(renderObject), AXScrollPositionChanged);
 }
 
 } // namespace WebCore