Source/core/html/HTMLTextFormControlElement.cpp - Issue 313013005: Set value of m_textAsOfLastFormControlChangeEvent before triggering change event

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 313013005: Set value of m_textAsOfLastFormControlChangeEvent before triggering change event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLTextFormControlElement.cpp

diff --git a/Source/core/html/HTMLTextFormControlElement.cpp b/Source/core/html/HTMLTextFormControlElement.cpp

index bf3597a17159f2e0cad756e6e8be0ffc25b2bc4c..8809d426b49a1731044e49664c0ede190b5c9c9d 100644

--- a/Source/core/html/HTMLTextFormControlElement.cpp

+++ b/Source/core/html/HTMLTextFormControlElement.cpp

@@ -191,8 +191,8 @@ void HTMLTextFormControlElement::dispatchFormControlChangeEvent()

{

String newValue = value();

if (shouldDispatchFormControlChangeEvent(m_textAsOfLastFormControlChangeEvent, newValue)) {

- dispatchChangeEvent();

setTextAsOfLastFormControlChangeEvent(newValue);

+ dispatchChangeEvent();

}

setChangedSinceLastFormControlChangeEvent(false);

}

« no previous file with comments | « LayoutTests/fast/events/onchange-js-expected.txt ('k') | no next file » | no next file with comments »