Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: Source/core/html/HTMLTextFormControlElement.cpp

Issue 313013005: Set value of m_textAsOfLastFormControlChangeEvent before triggering change event (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « LayoutTests/fast/events/onchange-js-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 6 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 184
185 bool HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(String& ol dValue, String& newValue) 185 bool HTMLTextFormControlElement::shouldDispatchFormControlChangeEvent(String& ol dValue, String& newValue)
186 { 186 {
187 return !equalIgnoringNullity(oldValue, newValue); 187 return !equalIgnoringNullity(oldValue, newValue);
188 } 188 }
189 189
190 void HTMLTextFormControlElement::dispatchFormControlChangeEvent() 190 void HTMLTextFormControlElement::dispatchFormControlChangeEvent()
191 { 191 {
192 String newValue = value(); 192 String newValue = value();
193 if (shouldDispatchFormControlChangeEvent(m_textAsOfLastFormControlChangeEven t, newValue)) { 193 if (shouldDispatchFormControlChangeEvent(m_textAsOfLastFormControlChangeEven t, newValue)) {
194 setTextAsOfLastFormControlChangeEvent(newValue);
194 dispatchChangeEvent(); 195 dispatchChangeEvent();
195 setTextAsOfLastFormControlChangeEvent(newValue);
196 } 196 }
197 setChangedSinceLastFormControlChangeEvent(false); 197 setChangedSinceLastFormControlChangeEvent(false);
198 } 198 }
199 199
200 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text) 200 static inline bool hasVisibleTextArea(RenderObject* renderer, HTMLElement* inner Text)
201 { 201 {
202 ASSERT(renderer); 202 ASSERT(renderer);
203 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height(); 203 return renderer->style()->visibility() != HIDDEN && innerText && innerText-> renderer() && innerText->renderBox()->height();
204 } 204 }
205 205
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 651
652 return "ltr"; 652 return "ltr";
653 } 653 }
654 654
655 HTMLElement* HTMLTextFormControlElement::innerTextElement() const 655 HTMLElement* HTMLTextFormControlElement::innerTextElement() const
656 { 656 {
657 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor())); 657 return toHTMLElement(userAgentShadowRoot()->getElementById(ShadowElementName s::innerEditor()));
658 } 658 }
659 659
660 } // namespace Webcore 660 } // namespace Webcore
OLDNEW
« no previous file with comments | « LayoutTests/fast/events/onchange-js-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698