Remove unused param from search engine extension override helper function.

Remove unused param from search engine extension override helper function.

BUG=None
R=rdevlin.cronin@chromium.org, sky@chromium.org
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276343

[Devlin, 2014-06-03 23:16:58]

https://codereview.chromium.org/312943002/diff/1/chrome/browser/extensions/se...
File chrome/browser/extensions/settings_api_helpers.h (right):

https://codereview.chromium.org/312943002/diff/1/chrome/browser/extensions/se...
chrome/browser/extensions/settings_api_helpers.h:36: std::vector<GURL>*
startup_pages);
it looks like these other ones (|home_page_url| in OverridesHomepage() and
|startup_pages| in OverridesStartupPages()) are just as unused... Do you plan to
remove them at later, are they going to be used soon, or should they also be
pulled out in this patch?

[Finnur, 2014-06-03 23:41:07]

On 2014/06/03 23:16:58, Devlin wrote:
>
https://codereview.chromium.org/312943002/diff/1/chrome/browser/extensions/se...
> File chrome/browser/extensions/settings_api_helpers.h (right):
> 
>
https://codereview.chromium.org/312943002/diff/1/chrome/browser/extensions/se...
> chrome/browser/extensions/settings_api_helpers.h:36: std::vector<GURL>*
> startup_pages);
> it looks like these other ones (|home_page_url| in OverridesHomepage() and
> |startup_pages| in OverridesStartupPages()) are just as unused... Do you plan
to
> remove them at later, are they going to be used soon, or should they also be
> pulled out in this patch?

Good point. Updated.

[Devlin, 2014-06-03 23:55:11]

lgtm

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/settings_api_helpers.cc (right):

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/settings_api_helpers.cc:17: // the SettingsOverride
object, or NULL if no |extension| is overriding that
nit: No longer returns the SettingsOverride object.

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/settings_api_helpers.h (right):

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/settings_api_helpers.h:17: // |browser_context|.
nit: an "if any" in the comments may be in order to indicate the possibility of
NULLness (though callers will likely know that).

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/settings_api_helpers.h:18: const Extension*
OverridesHomepage(content::BrowserContext* browser_context);
Is the change to make these methods GetExtensionOverridingX still going in? 
(Just curious, no need to hold up this patch.)

[Finnur, 2014-06-04 00:13:09]

All addressed.

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/settings_api_helpers.h (right):

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/settings_api_helpers.h:18: const Extension*
OverridesHomepage(content::BrowserContext* browser_context);
Wow... that's weird. I remember writing that change but now I can't find any
evidence that I did...

Anyway. Updated to include that.

[Finnur, 2014-06-04 00:13:17]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2014-06-04 00:13:18]

The CQ bit was unchecked by finnur@chromium.org

[Devlin, 2014-06-04 15:05:57]

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
File chrome/browser/extensions/settings_api_helpers.h (right):

https://codereview.chromium.org/312943002/diff/20001/chrome/browser/extension...
chrome/browser/extensions/settings_api_helpers.h:18: const Extension*
OverridesHomepage(content::BrowserContext* browser_context);
On 2014/06/04 00:13:09, Finnur wrote:
> Wow... that's weird. I remember writing that change but now I can't find any
> evidence that I did...
> 
> Anyway. Updated to include that.

The change was originally part of this patch:
https://codereview.chromium.org/288923004/
Looks like you got all the lg's, but were waiting on UI team?

[Finnur, 2014-06-05 20:59:51]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:01:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/finnur@chromium.org/312943002/80001

[Finnur, 2014-06-05 21:52:33]

The CQ bit was unchecked by finnur@chromium.org

[Finnur, 2014-06-10 11:37:05]

TBR-ing Scott for OWNERS check in browser/ui. (minor cleanup)

[Finnur, 2014-06-10 11:37:13]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2014-06-10 11:42:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/finnur@chromium.org/312943002/100001

[sky, 2014-06-10 16:11:43]

LGTM

[commit-bot: I haz the power, 2014-06-10 19:10:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[commit-bot: I haz the power, 2014-06-10 19:48:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 19:48:06]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)

[Finnur, 2014-06-11 11:06:31]

The CQ bit was checked by finnur@chromium.org

[Finnur, 2014-06-11 11:06:39]

The CQ bit was unchecked by finnur@chromium.org

[Finnur, 2014-06-11 11:06:42]

The CQ bit was checked by finnur@chromium.org

[commit-bot: I haz the power, 2014-06-11 11:09:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/finnur@chromium.org/312943002/100001

[Finnur, 2014-06-11 11:13:45]

Committed patchset #6 manually as r276343 (presubmit successful).