Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/ui/views/extensions/extension_message_bubble_view.cc

Issue 312943002: Remove unused param from search engine extension override helper function. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h" 5 #include "chrome/browser/ui/views/extensions/extension_message_bubble_view.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/string_util.h" 8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h" 10 #include "chrome/browser/extensions/dev_mode_bubble_controller.h"
(...skipping 330 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 return true; 341 return true;
342 } 342 }
343 343
344 bool ExtensionMessageBubbleFactory::MaybeShowStartupOverrideExtensionsBubble( 344 bool ExtensionMessageBubbleFactory::MaybeShowStartupOverrideExtensionsBubble(
345 views::View* anchor_view) { 345 views::View* anchor_view) {
346 #if !defined(OS_WIN) 346 #if !defined(OS_WIN)
347 return false; 347 return false;
348 #else 348 #else
349 DCHECK(!shown_startup_override_extensions_bubble_); 349 DCHECK(!shown_startup_override_extensions_bubble_);
350 350
351 const Extension* extension = 351 const Extension* extension = GetExtensionOverridingStartupPages(profile_);
352 GetExtensionOverridingStartupPages(profile_, NULL);
353 if (!extension) 352 if (!extension)
354 return false; 353 return false;
355 354
356 scoped_ptr<SettingsApiBubbleController> settings_api_bubble( 355 scoped_ptr<SettingsApiBubbleController> settings_api_bubble(
357 new SettingsApiBubbleController(profile_, 356 new SettingsApiBubbleController(profile_,
358 BUBBLE_TYPE_STARTUP_PAGES)); 357 BUBBLE_TYPE_STARTUP_PAGES));
359 if (!settings_api_bubble->ShouldShow(extension->id())) 358 if (!settings_api_bubble->ShouldShow(extension->id()))
360 return false; 359 return false;
361 360
362 shown_startup_override_extensions_bubble_ = true; 361 shown_startup_override_extensions_bubble_ = true;
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 } 504 }
506 505
507 void ExtensionMessageBubbleFactory::Finish() { 506 void ExtensionMessageBubbleFactory::Finish() {
508 MaybeStopObserving(); 507 MaybeStopObserving();
509 controller_.reset(); 508 controller_.reset();
510 anchor_view_ = NULL; 509 anchor_view_ = NULL;
511 container_ = NULL; 510 container_ = NULL;
512 } 511 }
513 512
514 } // namespace extensions 513 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/settings_api_helpers.cc ('k') | chrome/browser/ui/views/settings_api_bubble_helper_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698