content/renderer/media/rtc_video_decoder.cc - Issue 312803002: Android media: VideoFrame should not store so many sync points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_decoder.cc

Issue 312803002: Android media: VideoFrame should not store so many sync points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make VideoFrame keep only one sync point per client Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/android/webmediaplayer_android.cc ('K') | « content/renderer/media/rtc_video_decoder.h ('k') | content/renderer/media/video_capture_impl.h » ('j') | content/renderer/media/webmediaplayer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_video_decoder.cc

diff --git a/content/renderer/media/rtc_video_decoder.cc b/content/renderer/media/rtc_video_decoder.cc

index 3987767b353d1adabd16b73f3b297c3edf49d043..42926abf6d1a0baf7798aef69bd2c1b75c1f40f0 100644

--- a/content/renderer/media/rtc_video_decoder.cc

+++ b/content/renderer/media/rtc_video_decoder.cc

@@ -639,11 +639,15 @@ void RTCVideoDecoder::ReleaseMailbox(

const scoped_refptr<media::GpuVideoAcceleratorFactories>& factories,

int64 picture_buffer_id,

uint32 texture_id,

- const std::vector<uint32>& release_sync_points) {

+ const std::map<uintptr_t, uint32>& release_sync_points) {

DCHECK(factories->GetTaskRunner()->BelongsToCurrentThread());

- for (size_t i = 0; i < release_sync_points.size(); i++)

- factories->WaitSyncPoint(release_sync_points[i]);

+ for (std::map<uintptr_t, uint32>::const_iterator iter =

+ release_sync_points.begin();

+ iter != release_sync_points.end();

+ iter++) {

+ factories->WaitSyncPoint(iter->second);

+ }

if (decoder) {

decoder->ReusePictureBuffer(picture_buffer_id);