content/renderer/media/webmediaplayer_impl.cc - Issue 312803002: Android media: VideoFrame should not store so many sync points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/webmediaplayer_impl.cc

Issue 312803002: Android media: VideoFrame should not store so many sync points. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Make VideoFrame keep only one sync point per client Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/android/webmediaplayer_android.cc ('K') | « content/renderer/media/video_capture_message_filter.cc ('k') | media/base/video_frame.h » ('j') | media/base/video_frame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/webmediaplayer_impl.cc

diff --git a/content/renderer/media/webmediaplayer_impl.cc b/content/renderer/media/webmediaplayer_impl.cc

index d73f6bcec598a8a0425befbc7d7e311d0392b83a..f8b40ec51e734df5ea07abff2ce51cce2f24db7f 100644

--- a/content/renderer/media/webmediaplayer_impl.cc

+++ b/content/renderer/media/webmediaplayer_impl.cc

@@ -682,7 +682,10 @@ bool WebMediaPlayerImpl::copyVideoTextureToPlatformTexture(

web_graphics_context->deleteTexture(source_texture);

web_graphics_context->flush();

- video_frame->AppendReleaseSyncPoint(web_graphics_context->insertSyncPoint());

+ video_frame->AppendReleaseSyncPoint(

+ reinterpret_cast<uintptr_t>(web_graphics_context),

dshwang 2014/06/05 14:38:30 reinterpret_cast here

+ web_graphics_context->insertSyncPoint());

return true;

}