Source/modules/encoding/TextEncoder.idl - Issue 312683005: IDL: Support optional argument default value syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/encoding/TextEncoder.idl

Issue 312683005: IDL: Support optional argument default value syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/encoding/TextDecoder.idl ('K') | « Source/modules/encoding/TextDecoder.idl ('k') | Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.idl » ('j') | Source/modules/indexeddb/IDBDatabase.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/encoding/TextEncoder.idl

diff --git a/Source/modules/encoding/TextEncoder.idl b/Source/modules/encoding/TextEncoder.idl

index 243d2f8a03d26e14578f8fa626f86ed444950f74..e621bc97f831094a94a46c40792b859fc4e10c87 100644

--- a/Source/modules/encoding/TextEncoder.idl

+++ b/Source/modules/encoding/TextEncoder.idl

@@ -31,11 +31,11 @@

[

RuntimeEnabled=EncodingAPI,

Exposed=Window&Worker,

- Constructor([Default=NullString] optional DOMString utfLabel),

+ Constructor(optional DOMString utfLabel = null),

jsbell 2014/06/03 18:33:16 Per spec, default is "utf-8" - does everything pas

RaisesException=Constructor,

GarbageCollected,

MeasureAs=TextEncoderConstructor

] interface TextEncoder {

readonly attribute DOMString encoding;

- [MeasureAs=TextEncoderEncode] Uint8Array encode([Default=NullString] optional DOMString input, optional Dictionary options);

+ [MeasureAs=TextEncoderEncode] Uint8Array encode(optional DOMString input = null, optional Dictionary options);

jsbell 2014/06/03 18:33:16 Per spec, default is "" - does everything pass if

};