Source/modules/indexeddb/IDBDatabase.idl - Issue 312683005: IDL: Support optional argument default value syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/indexeddb/IDBDatabase.idl

Issue 312683005: IDL: Support optional argument default value syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/modules/encoding/TextEncoder.idl ('K') | « Source/modules/encryptedmedia/MediaKeys.idl ('k') | Source/modules/indexeddb/IDBIndex.idl » ('j') | Source/modules/indexeddb/IDBIndex.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/indexeddb/IDBDatabase.idl

diff --git a/Source/modules/indexeddb/IDBDatabase.idl b/Source/modules/indexeddb/IDBDatabase.idl

index 5ebbd32014242250ebbda72c3a0e0808248f3aec..41e8ff059f22c49b22d5334be1168039c1eacd96 100644

--- a/Source/modules/indexeddb/IDBDatabase.idl

+++ b/Source/modules/indexeddb/IDBDatabase.idl

@@ -36,9 +36,9 @@

[RaisesException] IDBObjectStore createObjectStore(DOMString name, optional Dictionary options);

[RaisesException] void deleteObjectStore(DOMString name);

// FIXME: should be union type http://crbug.com/240176

- [CallWith=ExecutionContext, RaisesException] IDBTransaction transaction(DOMString storeName, [Default=NullString] optional DOMString mode);

- [CallWith=ExecutionContext, RaisesException] IDBTransaction transaction(sequence<DOMString> storeNames, [Default=NullString] optional DOMString mode);

- [CallWith=ExecutionContext, RaisesException] IDBTransaction transaction(DOMStringList storeNames, [Default=NullString] optional DOMString mode);

+ [CallWith=ExecutionContext, RaisesException] IDBTransaction transaction(DOMString storeName, optional DOMString mode = null);

jsbell 2014/06/03 18:33:16 Per spec, the default is "readonly" - do all tests

+ [CallWith=ExecutionContext, RaisesException] IDBTransaction transaction(sequence<DOMString> storeNames, optional DOMString mode = null);

+ [CallWith=ExecutionContext, RaisesException] IDBTransaction transaction(DOMStringList storeNames, optional DOMString mode = null);

void close();

attribute EventHandler onabort;

attribute EventHandler onclose;