Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp - Issue 312683005: IDL: Support optional argument default value syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

Issue 312683005: IDL: Support optional argument default value syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp ('k') | Source/bindings/tests/results/V8TestObject.cpp » ('j') | Source/bindings/v8/V8StringResource.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

index 11a6d8e934595c6be6be6a0f0f926387a5087fd2..a9e85448d892bfecdff8269da65907d7d5daa1e4 100644

--- a/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp

@@ -110,7 +110,11 @@ static void V8TestInterfaceNamedConstructorConstructorCallback(const v8::Functio

TONATIVE_VOID_INTERNAL(defaultUndefinedOptionalBooleanArg, info[1]->BooleanValue());

TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(defaultUndefinedOptionalLongArg, toInt32(info[2], exceptionState), exceptionState);

TOSTRING_VOID_INTERNAL(defaultUndefinedOptionalStringArg, info[3]);

- TOSTRING_VOID_INTERNAL(defaultNullStringOptionalstringArg, argumentOrNull(info, 4));

+ if (info.Length() > 4) {

+ TOSTRING_VOID_INTERNAL(defaultNullStringOptionalstringArg, info[4]);

+ } else {

+ defaultNullStringOptionalstringArg = String();

+ }

if (UNLIKELY(info.Length() <= 5)) {

RefPtr<TestInterfaceNamedConstructor> impl = TestInterfaceNamedConstructor::createForJSConstructor(stringArg, defaultUndefinedOptionalBooleanArg, defaultUndefinedOptionalLongArg, defaultUndefinedOptionalStringArg, defaultNullStringOptionalstringArg);

v8::Handle<v8::Object> wrapper = info.Holder();