Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp - Issue 312683005: IDL: Support optional argument default value syntax

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

Issue 312683005: IDL: Support optional argument default value syntax (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/methods.cpp ('K') | « Source/bindings/tests/idls/TestObject.idl ('k') | Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp » ('j') | Source/bindings/v8/V8StringResource.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

diff --git a/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp b/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

index 7828bcc1a8b3350bc1a68bb01b39e97c7b3541f0..e4e8f40a16c9182501f21e33da7c038562f260b1 100644

--- a/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

+++ b/Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp

@@ -95,7 +95,11 @@ static void constructor3(const v8::FunctionCallbackInfo<v8::Value>& info)

TONATIVE_VOID_INTERNAL(testInterfaceEmptyArg, V8TestInterfaceEmpty::toNativeWithTypeCheck(info.GetIsolate(), info[0]));

TONATIVE_VOID_EXCEPTIONSTATE_INTERNAL(longArg, toInt32(info[1], exceptionState), exceptionState);

TOSTRING_VOID_INTERNAL(defaultUndefinedOptionalStringArg, info[2]);

- TOSTRING_VOID_INTERNAL(defaultNullStringOptionalStringArg, argumentOrNull(info, 3));

+ if (info.Length() > 3) {

+ TOSTRING_VOID_INTERNAL(defaultNullStringOptionalStringArg, info[3]);

+ } else {

+ defaultNullStringOptionalStringArg = String();

+ }

TONATIVE_VOID_INTERNAL(defaultUndefinedOptionalDictionaryArg, Dictionary(info[4], info.GetIsolate()));

if (!defaultUndefinedOptionalDictionaryArg.isUndefinedOrNull() && !defaultUndefinedOptionalDictionaryArg.isObject()) {

exceptionState.throwTypeError("parameter 5 ('defaultUndefinedOptionalDictionaryArg') is not an object.");